Skip to content

Commit 957efa4

Browse files
committed
Revert "[DebugInfo][RemoveDIs] Add prototype storage classes for "new" debug-info"
And some intervening fixups. There are two remaining problems: * A memory leak via https://lab.llvm.org/buildbot/#/builders/236/builds/7120/steps/10/logs/stdio * A performance slowdown with -g where I'm not completely sure what the cause it These might be fairly straightforwards to fix, but it's the end of the day hear, so I figure I'll clear the buildbots til tomorrow. This reverts commit 7d77bbe. This reverts commit 9026f35. This reverts commit d97b2b3.
1 parent 495ed8d commit 957efa4

25 files changed

+11
-1637
lines changed

llvm/include/llvm/IR/BasicBlock.h

Lines changed: 0 additions & 53 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919
#include "llvm/ADT/ilist_node.h"
2020
#include "llvm/ADT/iterator.h"
2121
#include "llvm/ADT/iterator_range.h"
22-
#include "llvm/IR/DebugProgramInstruction.h"
2322
#include "llvm/IR/Instruction.h"
2423
#include "llvm/IR/SymbolTableListTraits.h"
2524
#include "llvm/IR/Value.h"
@@ -57,9 +56,6 @@ class BasicBlock final : public Value, // Basic blocks are data objects also
5756
public ilist_node_with_parent<BasicBlock, Function> {
5857
public:
5958
using InstListType = SymbolTableList<Instruction, ilist_iterator_bits<true>>;
60-
/// Flag recording whether or not this block stores debug-info in the form
61-
/// of intrinsic instructions (false) or non-instruction records (true).
62-
bool IsNewDbgInfoFormat;
6359

6460
private:
6561
friend class BlockAddress;
@@ -68,55 +64,6 @@ class BasicBlock final : public Value, // Basic blocks are data objects also
6864
InstListType InstList;
6965
Function *Parent;
7066

71-
public:
72-
/// Attach a DPMarker to the given instruction. Enables the storage of any
73-
/// debug-info at this position in the program.
74-
DPMarker *createMarker(Instruction *I);
75-
DPMarker *createMarker(InstListType::iterator It);
76-
77-
/// Convert variable location debugging information stored in dbg.value
78-
/// intrinsics into DPMarker / DPValue records. Deletes all dbg.values in
79-
/// the process and sets IsNewDbgInfoFormat = true. Only takes effect if
80-
/// the UseNewDbgInfoFormat LLVM command line option is given.
81-
void convertToNewDbgValues();
82-
83-
/// Convert variable location debugging information stored in DPMarkers and
84-
/// DPValues into the dbg.value intrinsic representation. Sets
85-
/// IsNewDbgInfoFormat = false.
86-
void convertFromNewDbgValues();
87-
88-
/// Ensure the block is in "old" dbg.value format (\p NewFlag == false) or
89-
/// in the new format (\p NewFlag == true), converting to the desired format
90-
/// if necessary.
91-
void setIsNewDbgInfoFormat(bool NewFlag);
92-
93-
/// Validate any DPMarkers / DPValues attached to instructions in this block,
94-
/// and block-level stored data too (TrailingDPValues).
95-
/// \p Assert Should this method fire an assertion if a problem is found?
96-
/// \p Msg Should this method print a message to errs() if a problem is found?
97-
/// \p OS Output stream to write errors to.
98-
/// \returns True if a problem is found.
99-
bool validateDbgValues(bool Assert = true, bool Msg = false,
100-
raw_ostream *OS = nullptr);
101-
102-
/// Record that the collection of DPValues in \p M "trails" after the last
103-
/// instruction of this block. These are equivalent to dbg.value intrinsics
104-
/// that exist at the end of a basic block with no terminator (a transient
105-
/// state that occurs regularly).
106-
void setTrailingDPValues(DPMarker *M);
107-
108-
/// Fetch the collection of DPValues that "trail" after the last instruction
109-
/// of this block, see \ref setTrailingDPValues. If there are none, returns
110-
/// nullptr.
111-
DPMarker *getTrailingDPValues();
112-
113-
/// Delete any trailing DPValues at the end of this block, see
114-
/// \ref setTrailingDPValues.
115-
void deleteTrailingDPValues();
116-
117-
void dumpDbgValues() const;
118-
119-
private:
12067
void setParent(Function *parent);
12168

12269
/// Constructor.

llvm/include/llvm/IR/DebugInfoMetadata.h

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3765,10 +3765,6 @@ class DIArgList : public MDNode {
37653765
iterator args_begin() { return Args.begin(); }
37663766
iterator args_end() { return Args.end(); }
37673767

3768-
ReplaceableMetadataImpl *getReplaceableUses() {
3769-
return Context.getReplaceableUses();
3770-
}
3771-
37723768
static bool classof(const Metadata *MD) {
37733769
return MD->getMetadataID() == DIArgListKind;
37743770
}

0 commit comments

Comments
 (0)