Address comment, revert empty line change

GeorgeHuyubo · GeorgeHuyubo · commit 95d455be8a5b · 2024-05-24T10:56:02.000-07:00
diff --git a/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp b/lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp
@@ -276,10 +276,8 @@ Status ProcessElfCore::DoLoadCore() {
 }
 
 void ProcessElfCore::UpdateBuildIdForNTFileEntries() {
-  if (!m_nt_file_entries.empty()) {
-    for (NT_FILE_Entry &entry : m_nt_file_entries) {
-      entry.uuid = FindBuidIdInCoreMemory(entry.start);
-    }
+  for (NT_FILE_Entry &entry : m_nt_file_entries) {
+    entry.uuid = FindBuidIdInCoreMemory(entry.start);
   }
 }
 
@@ -585,6 +583,7 @@ llvm::Expected<std::vector<CoreNote>>
 ProcessElfCore::parseSegment(const DataExtractor &segment) {
   lldb::offset_t offset = 0;
   std::vector<CoreNote> result;
+
   while (offset < segment.GetByteSize()) {
     ELFNote note = ELFNote();
     if (!note.Parse(segment, &offset))

Original file line number	Diff line number	Diff line change
`@@ -276,10 +276,8 @@ Status ProcessElfCore::DoLoadCore() {`
`276`	`276`	`}`
`277`	`277`
`278`	`278`	`void ProcessElfCore::UpdateBuildIdForNTFileEntries() {`
`279`		`- if (!m_nt_file_entries.empty()) {`
`280`		`- for (NT_FILE_Entry &entry : m_nt_file_entries) {`
`281`		`- entry.uuid = FindBuidIdInCoreMemory(entry.start);`
`282`		`- }`
	`279`	`+ for (NT_FILE_Entry &entry : m_nt_file_entries) {`
	`280`	`+ entry.uuid = FindBuidIdInCoreMemory(entry.start);`
`283`	`281`	`}`
`284`	`282`	`}`
`285`	`283`
`@@ -585,6 +583,7 @@ llvm::Expected<std::vector<CoreNote>>`
`585`	`583`	`ProcessElfCore::parseSegment(const DataExtractor &segment) {`
`586`	`584`	`lldb::offset_t offset = 0;`
`587`	`585`	`std::vector<CoreNote> result;`
	`586`	`+`
`588`	`587`	`while (offset < segment.GetByteSize()) {`
`589`	`588`	`ELFNote note = ELFNote();`
`590`	`589`	`if (!note.Parse(segment, &offset))`