Skip to content

Commit 9615768

Browse files
author
Peiming Liu
committed
address comments
1 parent 21dbd17 commit 9615768

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

mlir/lib/Dialect/SparseTensor/Transforms/SparseTensorPasses.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,6 @@ struct LowerForeachToSCFPass
154154
auto *ctx = &getContext();
155155
RewritePatternSet patterns(ctx);
156156
populateLowerForeachToSCFPatterns(patterns);
157-
158157
(void)applyPatternsAndFoldGreedily(getOperation(), std::move(patterns));
159158
}
160159
};

mlir/lib/Dialect/SparseTensor/Transforms/Utils/SparseTensorIterator.h

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,6 +88,10 @@ enum class IterKind : uint8_t {
8888
kPad,
8989
};
9090

91+
/// A `SparseIterationSpace` represents a sparse set of coordinates defined by
92+
/// (possibly multiple) levels of a specific sparse tensor.
93+
/// TODO: remove `SparseTensorLevel` and switch to SparseIterationSpace when
94+
/// feature complete.
9195
class SparseIterationSpace {
9296
public:
9397
SparseIterationSpace() = default;
@@ -345,7 +349,7 @@ std::unique_ptr<SparseTensorLevel> makeSparseTensorLevel(OpBuilder &b,
345349
std::unique_ptr<SparseTensorLevel> makeSparseTensorLevel(LevelType lt, Value sz,
346350
ValueRange buffers,
347351
unsigned tid, Level l);
348-
/// Helper function to create a simple SparseIterator object that iterate
352+
/// Helper function to create a simple SparseIterator object that iterates
349353
/// over the SparseTensorLevel.
350354
std::unique_ptr<SparseIterator> makeSimpleIterator(
351355
const SparseTensorLevel &stl,

0 commit comments

Comments
 (0)