Skip to content

Commit 9651902

Browse files
committed
[lldb][DataFormatters] Make data-formatters log to the DataFormatters channel
Currently the data-formatters log to either DataFormatters or Types. The former is probably more sensible, so log there consistently from all formatters.
1 parent f11b3de commit 9651902

File tree

4 files changed

+8
-5
lines changed

4 files changed

+8
-5
lines changed

lldb/source/Plugins/Language/CPlusPlus/LibCxxInitializerList.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,8 @@ lldb_private::formatters::LibcxxInitializerListSyntheticFrontEnd::Update() {
9090

9191
llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr);
9292
if (!size_or_err)
93-
LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), size_or_err.takeError(), "{0}");
93+
LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(),
94+
"{0}");
9495
else {
9596
m_element_size = *size_or_err;
9697
// Store raw pointers or end up with a circular dependency.

lldb/source/Plugins/Language/CPlusPlus/LibCxxSpan.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,8 @@ lldb_private::formatters::LibcxxStdSpanSyntheticFrontEnd::Update() {
104104
// Get element size.
105105
llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr);
106106
if (!size_or_err)
107-
LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), size_or_err.takeError(), "{0}");
107+
LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(),
108+
"{0}");
108109
else {
109110
m_element_size = *size_or_err;
110111

lldb/source/Plugins/Language/CPlusPlus/LibCxxVariant.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,8 +99,8 @@ LibcxxVariantGetIndexValidity(ValueObjectSP &impl_sp) {
9999

100100
llvm::Expected<uint64_t> index_type_bytes = index_type.GetByteSize(nullptr);
101101
if (!index_type_bytes) {
102-
LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), index_type_bytes.takeError(),
103-
"{0}");
102+
LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters),
103+
index_type_bytes.takeError(), "{0}");
104104
if (!index_type_bytes)
105105
return LibcxxVariantIndexValidity::Invalid;
106106
}

lldb/source/Plugins/Language/CPlusPlus/LibCxxVector.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -150,7 +150,8 @@ lldb_private::formatters::LibcxxStdVectorSyntheticFrontEnd::Update() {
150150
m_element_type = data_sp->GetCompilerType().GetPointeeType();
151151
llvm::Expected<uint64_t> size_or_err = m_element_type.GetByteSize(nullptr);
152152
if (!size_or_err)
153-
LLDB_LOG_ERRORV(GetLog(LLDBLog::Types), size_or_err.takeError(), "{0}");
153+
LLDB_LOG_ERRORV(GetLog(LLDBLog::DataFormatters), size_or_err.takeError(),
154+
"{0}");
154155
else {
155156
m_element_size = *size_or_err;
156157

0 commit comments

Comments
 (0)