Skip to content

Commit 977c839

Browse files
committed
Address review comments
1 parent 136bdea commit 977c839

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

flang/lib/Lower/OpenMP/ClauseProcessor.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,6 +220,10 @@ static void convertLoopBounds(lower::AbstractConverter &converter,
220220
// ClauseProcessor unique clauses
221221
//===----------------------------------------------------------------------===//
222222

223+
bool ClauseProcessor::processBare(mlir::omp::BareClauseOps &result) const {
224+
return markClauseOccurrence<omp::clause::OmpxBare>(result.bare);
225+
}
226+
223227
bool ClauseProcessor::processBind(mlir::omp::BindClauseOps &result) const {
224228
if (auto *clause = findUniqueClause<omp::clause::Bind>()) {
225229
fir::FirOpBuilder &firOpBuilder = converter.getFirOpBuilder();
@@ -382,10 +386,6 @@ bool ClauseProcessor::processNowait(mlir::omp::NowaitClauseOps &result) const {
382386
return markClauseOccurrence<omp::clause::Nowait>(result.nowait);
383387
}
384388

385-
bool ClauseProcessor::processBare(mlir::omp::BareClauseOps &result) const {
386-
return markClauseOccurrence<omp::clause::OmpxBare>(result.bare);
387-
}
388-
389389
bool ClauseProcessor::processNumTeams(
390390
lower::StatementContext &stmtCtx,
391391
mlir::omp::NumTeamsClauseOps &result) const {

llvm/include/llvm/Frontend/OpenMP/ConstructDecompositionT.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -236,11 +236,11 @@ struct ConstructDecompositionT {
236236
const ClauseTy *);
237237
bool applyClause(const tomp::clause::NowaitT<TypeTy, IdTy, ExprTy> &clause,
238238
const ClauseTy *);
239-
bool applyClause(const tomp::clause::OmpxBareT<TypeTy, IdTy, ExprTy> &clause,
240-
const ClauseTy *);
241239
bool
242240
applyClause(const tomp::clause::OmpxAttributeT<TypeTy, IdTy, ExprTy> &clause,
243241
const ClauseTy *);
242+
bool applyClause(const tomp::clause::OmpxBareT<TypeTy, IdTy, ExprTy> &clause,
243+
const ClauseTy *);
244244

245245
uint32_t version;
246246
llvm::omp::Directive construct;
@@ -1109,7 +1109,7 @@ template <typename C, typename H>
11091109
bool ConstructDecompositionT<C, H>::applyClause(
11101110
const tomp::clause::OmpxBareT<TypeTy, IdTy, ExprTy> &clause,
11111111
const ClauseTy *node) {
1112-
return applyToAll(node);
1112+
return applyToOutermost(node);
11131113
}
11141114

11151115
template <typename C, typename H>

0 commit comments

Comments
 (0)