Skip to content

Commit 97da5e6

Browse files
authored
[GSYM] Remove redundant getInliningInfoForAddress call (#111136)
In DwarfTransformer::verify() line number information is retrieved for each address using: auto DwarfInlineInfos = DICtx.getInliningInfoForAddress(SectAddr, DLIS); Later down the loop, another such invocation was made before: Gsym->dump(Log, *FI); There is a continue after that, DwarfInlineInfos do not affect the dump() invocation, I am not aware of any other side effects that is needed from the extra getInliningInfoForAddress() invocation, and tests pass without it, so just remove it.
1 parent 5f2cf99 commit 97da5e6

File tree

1 file changed

+0
-1
lines changed

1 file changed

+0
-1
lines changed

llvm/lib/DebugInfo/GSYM/DwarfTransformer.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -699,7 +699,6 @@ llvm::Error DwarfTransformer::verify(StringRef GsymPath,
699699
Log << " [" << Idx << "]: " << gii.Name << " @ " << gii.Dir
700700
<< '/' << gii.Base << ':' << gii.Line << '\n';
701701
}
702-
DwarfInlineInfos = DICtx.getInliningInfoForAddress(SectAddr, DLIS);
703702
Gsym->dump(Log, *FI);
704703
}
705704
continue;

0 commit comments

Comments
 (0)