Skip to content

Commit 9847c59

Browse files
committed
Address review feedback
1 parent 468cfd6 commit 9847c59

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

clang/lib/Serialization/ASTReader.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5834,12 +5834,13 @@ bool ASTReader::readASTFileControlBlock(
58345834
break;
58355835
case INPUT_FILE:
58365836
bool Overridden = static_cast<bool>(Record[3]);
5837-
size_t FilenameLen = ModuleDir.size() + Record[7] + 1;
5838-
auto Filename = ResolveImportedPath(PathBuf, Blob, ModuleDir);
5839-
StringRef FilenameAsRequested = Filename->substr(0, FilenameLen);
5840-
StringRef ExternalFilename = Filename->substr(FilenameLen);
5837+
const size_t FilenameAsRequestedLength = Record[7] + 1;
5838+
auto ResolvedFilenameAsRequested = ResolveImportedPath(
5839+
PathBuf, Blob.substr(0, FilenameAsRequestedLength), ModuleDir);
5840+
StringRef ExternalFilename = Blob.substr(FilenameAsRequestedLength);
58415841
shouldContinue = Listener.visitInputFile(
5842-
FilenameAsRequested, ExternalFilename, isSystemFile, Overridden,
5842+
ResolvedFilenameAsRequested->str(), ExternalFilename,
5843+
isSystemFile, Overridden,
58435844
/*IsExplicitModule=*/false);
58445845
break;
58455846
}

clang/test/ClangScanDeps/prebuilt-modules-in-stable-dirs.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
/// resolve `is-in-stable-directories` correctly.
33
/// The steps are:
44
/// 1. Scan dependencies to build the PCH. One of the module's depend on header
5-
/// that is seemingly from the sysroot. However, it depends on a local header that is overlaid..
5+
/// that is seemingly from the sysroot. However, it depends on a local header that is overlaid.
66
/// 2. Build the PCH & dependency PCMs.
77
/// 3. Scan a source file that transitively depends on the same modules as the pcm.
88

0 commit comments

Comments
 (0)