Skip to content

Commit 9afcd59

Browse files
committed
Remove unnecessary comments
1 parent d37e648 commit 9afcd59

File tree

3 files changed

+2
-3
lines changed

3 files changed

+2
-3
lines changed

clang/test/CodeGenCoroutines/coro-symmetric-transfer-01.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,6 @@ detached_task foo() {
4747
co_return;
4848
}
4949

50-
// FIXME: is this test needed now?
5150
// check that the lifetime of the coroutine handle used to obtain the address is contained within single basic block, and hence does not live across suspension points.
5251
// CHECK-LABEL: final.suspend:
5352
// CHECK: %{{.+}} = call token @llvm.coro.save(ptr null)

clang/test/CodeGenCoroutines/pr59181.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,6 @@ void foo() {
4848
bar(true);
4949
}
5050

51-
// FIXME: the test doesn't seem to be relevant anymore,
52-
// because objects that require cleanup are no more emitted in the suspend block
5351
// CHECK: cleanup.cont:{{.*}}
5452
// CHECK-NEXT: load i8
5553
// CHECK-NEXT: trunc

llvm/lib/Transforms/Coroutines/CoroSplit.cpp

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -169,6 +169,8 @@ class CoroCloner {
169169

170170
// FIXME:
171171
// Lower the intrinisc earlier if coroutine frame doesn't escape
172+
// and it is known that other transformations, for example, sanitizers
173+
// won't lead to incorrect code.
172174
static void lowerAwaitSuspend(IRBuilder<> &Builder, CoroAwaitSuspendInst *CB) {
173175
auto Wrapper = CB->getWrapperFunction();
174176
auto Awaiter = CB->getAwaiter();

0 commit comments

Comments
 (0)