[clangd] Fix JSON conversion for symbol tags (#84747)

ckandeler · web-flow · commit 9b2386e82ded · 2024-03-11T13:16:58.000+01:00
The wrong constructor of json::Value got called, making every tag an
array instead of a number.
diff --git a/clang-tools-extra/clangd/Protocol.cpp b/clang-tools-extra/clangd/Protocol.cpp
@@ -1412,7 +1412,7 @@ bool fromJSON(const llvm::json::Value &Params, ReferenceParams &R,
 }
 
 llvm::json::Value toJSON(SymbolTag Tag) {
-  return llvm::json::Value{static_cast<int>(Tag)};
+  return llvm::json::Value(static_cast<int>(Tag));
 }
 
 llvm::json::Value toJSON(const CallHierarchyItem &I) {

Original file line number	Diff line number	Diff line change
`@@ -1412,7 +1412,7 @@ bool fromJSON(const llvm::json::Value &Params, ReferenceParams &R,`
`1412`	`1412`	`}`
`1413`	`1413`
`1414`	`1414`	`llvm::json::Value toJSON(SymbolTag Tag) {`
`1415`		`- return llvm::json::Value{static_cast<int>(Tag)};`
	`1415`	`+ return llvm::json::Value(static_cast<int>(Tag));`
`1416`	`1416`	`}`
`1417`	`1417`
`1418`	`1418`	`llvm::json::Value toJSON(const CallHierarchyItem &I) {`