Skip to content

Commit 9b72907

Browse files
committed
fix failing tests, adjust for attr on handle member now
1 parent 662fed9 commit 9b72907

File tree

3 files changed

+27
-20
lines changed

3 files changed

+27
-20
lines changed

clang/test/Misc/pragma-attribute-supported-attributes-list.test

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@
8282
// CHECK-NEXT: GNUInline (SubjectMatchRule_function)
8383
// CHECK-NEXT: HIPManaged (SubjectMatchRule_variable)
8484
// CHECK-NEXT: HLSLROV (SubjectMatchRule_record_not_is_union)
85-
// CHECK-NEXT: HLSLResourceClass (SubjectMatchRule_record_not_is_union)
85+
// CHECK-NEXT: HLSLResourceClass (SubjectMatchRule_field)
8686
// CHECK-NEXT: Hot (SubjectMatchRule_function)
8787
// CHECK-NEXT: HybridPatchable (SubjectMatchRule_function)
8888
// CHECK-NEXT: IBAction (SubjectMatchRule_objc_method_is_instance)

clang/test/ParserHLSL/hlsl_resource_class_attr.hlsl

Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -ast-dump -o - %s | FileCheck %s
22

33

4-
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:31> SRV
5-
struct [[hlsl::resource_class(SRV)]] Eg1 {
6-
int i;
4+
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:26> SRV
5+
struct Eg1 {
6+
[[hlsl::resource_class(SRV)]] int i;
77
};
88

99
Eg1 e1;
1010

11-
// CHECK: -CXXRecordDecl 0x{{[0-9a-f]+}} <line:13:1, line:15:1> line:13:38 referenced struct Eg2 definition
12-
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:31> UAV
13-
struct [[hlsl::resource_class(UAV)]] Eg2 {
14-
int i;
11+
// CHECK: -CXXRecordDecl 0x{{[0-9a-f]+}} <line:13:1, line:15:1> line:13:8 referenced struct Eg2 definition
12+
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:26> UAV
13+
struct Eg2 {
14+
[[hlsl::resource_class(UAV)]] int i;
1515
};
1616
Eg2 e2;
1717

18-
// CHECK: -CXXRecordDecl 0x{{[0-9a-f]+}} <line:20:1, line:22:1> line:20:42 referenced struct Eg3 definition
19-
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:31> CBuffer
20-
struct [[hlsl::resource_class(CBuffer)]] Eg3 {
21-
int i;
18+
// CHECK: -CXXRecordDecl 0x{{[0-9a-f]+}} <line:20:1, line:22:1> line:20:8 referenced struct Eg3 definition
19+
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:26> CBuffer
20+
struct Eg3 {
21+
[[hlsl::resource_class(CBuffer)]] int i;
2222
};
2323
Eg3 e3;
2424

25-
// CHECK: -CXXRecordDecl 0x{{[0-9a-f]+}} <line:27:1, line:29:1> line:27:42 referenced struct Eg4 definition
26-
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:31> Sampler
27-
struct [[hlsl::resource_class(Sampler)]] Eg4 {
28-
int i;
25+
// CHECK: -CXXRecordDecl 0x{{[0-9a-f]+}} <line:27:1, line:29:1> line:27:8 referenced struct Eg4 definition
26+
// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <col:26> Sampler
27+
struct Eg4 {
28+
[[hlsl::resource_class(Sampler)]] int i;
2929
};
3030
Eg4 e4;
3131

Lines changed: 11 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,22 @@
11
// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -ast-dump -o - %s -verify
22

3+
struct Eg1 {
34
// expected-error@+1{{'resource_class' attribute takes one argument}}
4-
struct [[hlsl::resource_class()]] Eg1 {
5-
int i;
5+
[[hlsl::resource_class()]] int i;
66
};
77

88
Eg1 e1;
99

10+
struct Eg2 {
1011
// expected-warning@+1{{ResourceClass attribute argument not supported: gibberish}}
11-
struct [[hlsl::resource_class(gibberish)]] Eg2 {
12-
int i;
12+
[[hlsl::resource_class(gibberish)]] int i;
1313
};
1414

1515
Eg2 e2;
16+
17+
// expected-warning@+1{{'resource_class' attribute only applies to non-static data members}}
18+
struct [[hlsl::resource_class(SRV)]] Eg3 {
19+
int i;
20+
};
21+
22+
Eg3 e3;

0 commit comments

Comments
 (0)