Skip to content

Commit 9bdcea2

Browse files
committed
remove tbuffer as a resource class
1 parent 1edee6e commit 9bdcea2

File tree

2 files changed

+14
-15
lines changed

2 files changed

+14
-15
lines changed

clang/lib/Sema/SemaDeclAttr.cpp

Lines changed: 14 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -7377,13 +7377,7 @@ static void DiagnoseHLSLResourceRegType(Sema &S, SourceLocation &ArgLoc,
73777377
DeclResourceClass = Attr->getResourceClass();
73787378
VarTy = TheRecordDecl->getName();
73797379
} else {
7380-
if (CBufferOrTBuffer->isCBuffer()) {
7381-
DeclResourceClass = llvm::hlsl::ResourceClass::CBuffer;
7382-
VarTy = "cbuffer";
7383-
} else {
7384-
DeclResourceClass = llvm::hlsl::ResourceClass::TBuffer;
7385-
VarTy = "tbuffer";
7386-
}
7380+
DeclResourceClass = llvm::hlsl::ResourceClass::CBuffer;
73877381
}
73887382
switch (DeclResourceClass) {
73897383
case llvm::hlsl::ResourceClass::SRV: {
@@ -7397,13 +7391,19 @@ static void DiagnoseHLSLResourceRegType(Sema &S, SourceLocation &ArgLoc,
73977391
break;
73987392
}
73997393
case llvm::hlsl::ResourceClass::CBuffer: {
7400-
if (Slot[0] == 'b')
7401-
return;
7402-
break;
7403-
}
7404-
case llvm::hlsl::ResourceClass::TBuffer: {
7405-
if (Slot[0] == 't')
7406-
return;
7394+
// could be CBuffer or TBuffer
7395+
if (CBufferOrTBuffer->isCBuffer()) {
7396+
VarTy = "cbuffer";
7397+
if (Slot[0] == 'b')
7398+
return;
7399+
} else {
7400+
VarTy = "tbuffer";
7401+
// This isn't an SRV, but we need the diagnostic to emit
7402+
// the same binding prefix that would be expected on an SRV.
7403+
DeclResourceClass = llvm::hlsl::ResourceClass::SRV;
7404+
if (Slot[0] == 't')
7405+
return;
7406+
}
74077407
break;
74087408
}
74097409
case llvm::hlsl::ResourceClass::Sampler: {

llvm/include/llvm/Frontend/HLSL/HLSLResource.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ enum class ResourceClass : uint8_t {
2525
SRV = 0,
2626
UAV,
2727
CBuffer,
28-
TBuffer,
2928
Sampler,
3029
Invalid,
3130
NumClasses = Invalid,

0 commit comments

Comments
 (0)