Lowercase error messages and port over more calls

Error messages should be lower case, so all of them have been changed.
In addition, a few more string error creations have been ported to
use offload errors, which also meant moving some reporting things to
OffloadError.h.

Author: RossBrunton

offload/include/Shared/OffloadErrcodes.inc

@@ -14,38 +14,38 @@
 // To add new error codes, add them to offload/liboffload/API/Common.td and run
 // the GenerateOffload target.
 
-OFFLOAD_ERRC(SUCCESS, "Success", 0)
-OFFLOAD_ERRC(UNKNOWN, "Unknown or internal error", 1)
+OFFLOAD_ERRC(SUCCESS, "success", 0)
+OFFLOAD_ERRC(UNKNOWN, "unknown or internal error", 1)
 OFFLOAD_ERRC(HOST_IO, "I/O error on host", 2)
-OFFLOAD_ERRC(INVALID_BINARY, "A provided binary image is malformed", 3)
+OFFLOAD_ERRC(INVALID_BINARY, "a provided binary image is malformed", 3)
 OFFLOAD_ERRC(INVALID_NULL_POINTER,
-             "A pointer argument is null when it should not be", 4)
-OFFLOAD_ERRC(INVALID_ARGUMENT, "An argument is invalid", 5)
-OFFLOAD_ERRC(NOT_FOUND, "Requested object was not found in the binary image", 6)
-OFFLOAD_ERRC(OUT_OF_RESOURCES, "Out of resources", 7)
+             "a pointer argument is null when it should not be", 4)
+OFFLOAD_ERRC(INVALID_ARGUMENT, "an argument is invalid", 5)
+OFFLOAD_ERRC(NOT_FOUND, "requested object was not found in the binary image", 6)
+OFFLOAD_ERRC(OUT_OF_RESOURCES, "out of resources", 7)
 OFFLOAD_ERRC(
     INVALID_SIZE,
     "invalid size or dimensions (e.g., must not be zero, or is out of bounds)",
     8)
 OFFLOAD_ERRC(INVALID_ENUMERATION, "enumerator argument is not valid", 9)
 OFFLOAD_ERRC(HOST_TOOL_NOT_FOUND,
-             "A required binary (linker, etc.) was not found on the host", 10)
-OFFLOAD_ERRC(INVALID_VALUE, "Invalid Value", 11)
+             "a required binary (linker, etc.) was not found on the host", 10)
+OFFLOAD_ERRC(INVALID_VALUE, "invalid value", 11)
 OFFLOAD_ERRC(UNIMPLEMENTED,
-             "Generic error code for features currently unimplemented by the "
+             "generic error code for features currently unimplemented by the "
              "device/backend",
              12)
 OFFLOAD_ERRC(
     UNSUPPORTED,
-    "Generic error code for features unsupported by the device/backend", 13)
+    "generic error code for features unsupported by the device/backend", 13)
 OFFLOAD_ERRC(ASSEMBLE_FAILURE,
-             "Assembler failure while processing binary image", 14)
-OFFLOAD_ERRC(LINK_FAILURE, "Linker failure while processing binary image", 15)
+             "assembler failure while processing binary image", 14)
+OFFLOAD_ERRC(LINK_FAILURE, "linker failure while processing binary image", 15)
 OFFLOAD_ERRC(BACKEND_FAILURE,
-             "The plugin backend is in an invalid or unsupported state", 16)
+             "the plugin backend is in an invalid or unsupported state", 16)
 OFFLOAD_ERRC(INVALID_NULL_HANDLE,
-             "A handle argument is null when it should not be", 17)
-OFFLOAD_ERRC(INVALID_PLATFORM, "Invalid platform", 18)
-OFFLOAD_ERRC(INVALID_DEVICE, "Invalid device", 19)
-OFFLOAD_ERRC(INVALID_QUEUE, "Invalid queue", 20)
-OFFLOAD_ERRC(INVALID_EVENT, "Invalid event", 21)
+             "a handle argument is null when it should not be", 17)
+OFFLOAD_ERRC(INVALID_PLATFORM, "invalid platform", 18)
+OFFLOAD_ERRC(INVALID_DEVICE, "invalid device", 19)
+OFFLOAD_ERRC(INVALID_QUEUE, "invalid queue", 20)
+OFFLOAD_ERRC(INVALID_EVENT, "invalid event", 21)

offload/include/Shared/OffloadError.h

@@ -46,6 +46,40 @@ class OffloadError : public llvm::ErrorInfo<OffloadError, llvm::StringError> {
   // The definition for this resides in the plugin static library
   static char ID;
 };
+
+/// Create an Offload error.
+template <typename... ArgsTy>
+static llvm::Error createOffloadError(error::ErrorCode Code, const char *ErrFmt, ArgsTy... Args) {
+  std::string Buffer;
+  llvm::raw_string_ostream(Buffer) << llvm::format(ErrFmt, Args...);
+  return llvm::make_error<error::OffloadError>(Code, Buffer);
+}
+
+inline llvm::Error createOffloadError(error::ErrorCode Code, const char *S) {
+  return llvm::make_error<error::OffloadError>(Code, S);
+}
+
+// The OffloadError will have a message of either:
+// * "{Context}: {Message}" if the other error is a StringError
+// * "{Context}" otherwise
+inline llvm::Error createOffloadError(error::ErrorCode Code, llvm::Error &&OtherError,
+                   const char *Context) {
+  std::string Buffer{Context};
+  llvm::raw_string_ostream buffer(Buffer);
+
+  handleAllErrors(
+      std::move(OtherError),
+      [&](llvm::StringError &Err) {
+        buffer << ": ";
+        buffer << Err.getMessage();
+      },
+      [&](llvm::ErrorInfoBase &Err) {
+        // Non-string error message don't add anything to the offload error's
+        // error message
+      });
+
+  return llvm::make_error<error::OffloadError>(Code, Buffer);
+}
 } // namespace error
 
 #endif

offload/liboffload/API/Common.td

@@ -87,32 +87,32 @@ def ErrorCode : Enum {
   let name = "ol_errc_t";
   let desc = "Defines Return/Error codes";
   let etors =[
-    Etor<"SUCCESS", "Success">,
+    Etor<"SUCCESS", "success">,
 
     // Universal errors
-    Etor<"UNKNOWN", "Unknown or internal error">,
+    Etor<"UNKNOWN", "unknown or internal error">,
     Etor<"HOST_IO", "I/O error on host">,
-    Etor<"INVALID_BINARY", "A provided binary image is malformed">,
-    Etor<"INVALID_NULL_POINTER", "A pointer argument is null when it should not be">,
-    Etor<"INVALID_ARGUMENT", "An argument is invalid">,
-    Etor<"NOT_FOUND", "Requested object was not found in the binary image">,
-    Etor<"OUT_OF_RESOURCES", "Out of resources">,
+    Etor<"INVALID_BINARY", "a provided binary image is malformed">,
+    Etor<"INVALID_NULL_POINTER", "a pointer argument is null when it should not be">,
+    Etor<"INVALID_ARGUMENT", "an argument is invalid">,
+    Etor<"NOT_FOUND", "requested object was not found in the binary image">,
+    Etor<"OUT_OF_RESOURCES", "out of resources">,
     Etor<"INVALID_SIZE", "invalid size or dimensions (e.g., must not be zero, or is out of bounds)">,
     Etor<"INVALID_ENUMERATION", "enumerator argument is not valid">,
-    Etor<"HOST_TOOL_NOT_FOUND", "A required binary (linker, etc.) was not found on the host">,
-    Etor<"INVALID_VALUE", "Invalid Value">,
-    Etor<"UNIMPLEMENTED", "Generic error code for features currently unimplemented by the device/backend">,
-    Etor<"UNSUPPORTED", "Generic error code for features unsupported by the device/backend">,
-    Etor<"ASSEMBLE_FAILURE", "Assembler failure while processing binary image">,
-    Etor<"LINK_FAILURE", "Linker failure while processing binary image">,
-    Etor<"BACKEND_FAILURE", "The plugin backend is in an invalid or unsupported state">,
+    Etor<"HOST_TOOL_NOT_FOUND", "a required binary (linker, etc.) was not found on the host">,
+    Etor<"INVALID_VALUE", "invalid value">,
+    Etor<"UNIMPLEMENTED", "generic error code for features currently unimplemented by the device/backend">,
+    Etor<"UNSUPPORTED", "generic error code for features unsupported by the device/backend">,
+    Etor<"ASSEMBLE_FAILURE", "assembler failure while processing binary image">,
+    Etor<"LINK_FAILURE", "linker failure while processing binary image">,
+    Etor<"BACKEND_FAILURE", "the plugin backend is in an invalid or unsupported state">,
 
     // Handle related errors - only makes sense for liboffload
-    Etor<"INVALID_NULL_HANDLE", "A handle argument is null when it should not be">,
-    Etor<"INVALID_PLATFORM", "Invalid platform">,
-    Etor<"INVALID_DEVICE", "Invalid device">,
-    Etor<"INVALID_QUEUE", "Invalid queue">,
-    Etor<"INVALID_EVENT", "Invalid event">,
+    Etor<"INVALID_NULL_HANDLE", "a handle argument is null when it should not be">,
+    Etor<"INVALID_PLATFORM", "invalid platform">,
+    Etor<"INVALID_DEVICE", "invalid device">,
+    Etor<"INVALID_QUEUE", "invalid queue">,
+    Etor<"INVALID_EVENT", "invalid event">,
   ];
 }
 

offload/liboffload/include/generated/OffloadAPI.h

@@ -20,50 +20,50 @@ extern "C" {
 ///////////////////////////////////////////////////////////////////////////////
 /// @brief Defines Return/Error codes
 typedef enum ol_errc_t {
-  /// Success
+  /// success
   OL_ERRC_SUCCESS = 0,
-  /// Unknown or internal error
+  /// unknown or internal error
   OL_ERRC_UNKNOWN = 1,
   /// I/O error on host
   OL_ERRC_HOST_IO = 2,
-  /// A provided binary image is malformed
+  /// a provided binary image is malformed
   OL_ERRC_INVALID_BINARY = 3,
-  /// A pointer argument is null when it should not be
+  /// a pointer argument is null when it should not be
   OL_ERRC_INVALID_NULL_POINTER = 4,
-  /// An argument is invalid
+  /// an argument is invalid
   OL_ERRC_INVALID_ARGUMENT = 5,
-  /// Requested object was not found in the binary image
+  /// requested object was not found in the binary image
   OL_ERRC_NOT_FOUND = 6,
-  /// Out of resources
+  /// out of resources
   OL_ERRC_OUT_OF_RESOURCES = 7,
   /// invalid size or dimensions (e.g., must not be zero, or is out of bounds)
   OL_ERRC_INVALID_SIZE = 8,
   /// enumerator argument is not valid
   OL_ERRC_INVALID_ENUMERATION = 9,
-  /// A required binary (linker, etc.) was not found on the host
+  /// a required binary (linker, etc.) was not found on the host
   OL_ERRC_HOST_TOOL_NOT_FOUND = 10,
-  /// Invalid Value
+  /// invalid value
   OL_ERRC_INVALID_VALUE = 11,
-  /// Generic error code for features currently unimplemented by the
+  /// generic error code for features currently unimplemented by the
   /// device/backend
   OL_ERRC_UNIMPLEMENTED = 12,
-  /// Generic error code for features unsupported by the device/backend
+  /// generic error code for features unsupported by the device/backend
   OL_ERRC_UNSUPPORTED = 13,
-  /// Assembler failure while processing binary image
+  /// assembler failure while processing binary image
   OL_ERRC_ASSEMBLE_FAILURE = 14,
-  /// Linker failure while processing binary image
+  /// linker failure while processing binary image
   OL_ERRC_LINK_FAILURE = 15,
-  /// The plugin backend is in an invalid or unsupported state
+  /// the plugin backend is in an invalid or unsupported state
   OL_ERRC_BACKEND_FAILURE = 16,
-  /// A handle argument is null when it should not be
+  /// a handle argument is null when it should not be
   OL_ERRC_INVALID_NULL_HANDLE = 17,
-  /// Invalid platform
+  /// invalid platform
   OL_ERRC_INVALID_PLATFORM = 18,
-  /// Invalid device
+  /// invalid device
   OL_ERRC_INVALID_DEVICE = 19,
-  /// Invalid queue
+  /// invalid queue
   OL_ERRC_INVALID_QUEUE = 20,
-  /// Invalid event
+  /// invalid event
   OL_ERRC_INVALID_EVENT = 21,
   /// @cond
   OL_ERRC_FORCE_UINT32 = 0x7fffffff

offload/libomptarget/PluginManager.cpp

@@ -538,9 +538,9 @@ Expected<DeviceTy &> PluginManager::getDevice(uint32_t DeviceNo) {
   {
     auto ExclusiveDevicesAccessor = getExclusiveDevicesAccessor();
     if (DeviceNo >= ExclusiveDevicesAccessor->size())
-      return createStringError(
-          inconvertibleErrorCode(),
-          "Device number '%i' out of range, only %i devices available",
+      return error::createOffloadError(
+          error::ErrorCode::INVALID_VALUE,
+          "device number '%i' out of range, only %i devices available",
           DeviceNo, ExclusiveDevicesAccessor->size());
 
     DevicePtr = &*(*ExclusiveDevicesAccessor)[DeviceNo];
@@ -549,8 +549,8 @@ Expected<DeviceTy &> PluginManager::getDevice(uint32_t DeviceNo) {
   // Check whether global data has been mapped for this device
   if (DevicePtr->hasPendingImages())
     if (loadImagesOntoDevice(*DevicePtr) != OFFLOAD_SUCCESS)
-      return createStringError(inconvertibleErrorCode(),
-                               "Failed to load images on device '%i'",
-                               DeviceNo);
+      return error::createOffloadError(error::ErrorCode::BACKEND_FAILURE,
+                                       "failed to load images on device '%i'",
+                                       DeviceNo);
   return *DevicePtr;
 }

offload/libomptarget/device.cpp

@@ -79,9 +79,9 @@ DeviceTy::~DeviceTy() {
 llvm::Error DeviceTy::init() {
   int32_t Ret = RTL->init_device(RTLDeviceID);
   if (Ret != OFFLOAD_SUCCESS)
-    return llvm::createStringError(llvm::inconvertibleErrorCode(),
-                                   "Failed to initialize device %d\n",
-                                   DeviceID);
+    return error::createOffloadError(error::ErrorCode::BACKEND_FAILURE,
+                                     "failed to initialize device %d\n",
+                                     DeviceID);
 
   // Enables recording kernels if set.
   BoolEnvar OMPX_RecordKernel("LIBOMPTARGET_RECORD", false);
@@ -103,8 +103,8 @@ DeviceTy::loadBinary(__tgt_device_image *Img) {
   __tgt_device_binary Binary;
 
   if (RTL->load_binary(RTLDeviceID, Img, &Binary) != OFFLOAD_SUCCESS)
-    return llvm::createStringError(llvm::inconvertibleErrorCode(),
-                                   "Failed to load binary %p", Img);
+    return error::createOffloadError(error::ErrorCode::INVALID_BINARY,
+                                     "failed to load binary %p", Img);
   return Binary;
 }