Skip to content

Commit 9db0e72

Browse files
LebedevRILebedevRI
committed
[X86] AMD Piledriver (BdVer2): major cleanup (mainly inverse throughput)
I've started this cleanup more several times now, but got sidetracked elsewhere, e.g. by llvm-exegesis problems. Not this time, finally! This is mainly cleaning up the inverse throughput values, and a few latencies/uops, based on the llvm-exegesis measured values. Though this is not complete by any means, there's certainly more cleanup to be done. The performance numbers (i've only checked by RawSpeed benchmark) aren't really surprising - overall this *slightly* (< -1%) improves perf. llvm-svn: 360341
1 parent 012adfb commit 9db0e72

File tree

82 files changed

+6540
-6441
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

82 files changed

+6540
-6441
lines changed

‎llvm/lib/Target/X86/X86ScheduleBdVer2.td

Lines changed: 303 additions & 209 deletions
Large diffs are not rendered by default.

‎llvm/test/tools/llvm-mca/X86/BdVer2/add-sequence.s

Lines changed: 46 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -7,13 +7,13 @@ add %eax, %edx
77

88
# CHECK: Iterations: 1000
99
# CHECK-NEXT: Instructions: 3000
10-
# CHECK-NEXT: Total Cycles: 1504
10+
# CHECK-NEXT: Total Cycles: 3003
1111
# CHECK-NEXT: Total uOps: 3000
1212

1313
# CHECK: Dispatch Width: 4
14-
# CHECK-NEXT: uOps Per Cycle: 1.99
15-
# CHECK-NEXT: IPC: 1.99
16-
# CHECK-NEXT: Block RThroughput: 1.5
14+
# CHECK-NEXT: uOps Per Cycle: 1.00
15+
# CHECK-NEXT: IPC: 1.00
16+
# CHECK-NEXT: Block RThroughput: 3.0
1717

1818
# CHECK: Instruction Info:
1919
# CHECK-NEXT: [1]: #uOps
@@ -24,9 +24,9 @@ add %eax, %edx
2424
# CHECK-NEXT: [6]: HasSideEffects (U)
2525

2626
# CHECK: [1] [2] [3] [4] [5] [6] Instructions:
27-
# CHECK-NEXT: 1 1 0.50 addl %eax, %ecx
28-
# CHECK-NEXT: 1 1 0.50 addl %esi, %eax
29-
# CHECK-NEXT: 1 1 0.50 addl %eax, %edx
27+
# CHECK-NEXT: 1 1 1.00 addl %eax, %ecx
28+
# CHECK-NEXT: 1 1 1.00 addl %esi, %eax
29+
# CHECK-NEXT: 1 1 1.00 addl %eax, %edx
3030

3131
# CHECK: Resources:
3232
# CHECK-NEXT: [0.0] - PdAGLU01
@@ -55,48 +55,48 @@ add %eax, %edx
5555

5656
# CHECK: Resource pressure per iteration:
5757
# CHECK-NEXT: [0.0] [0.1] [1] [2] [3] [4] [5] [6] [7.0] [7.1] [8.0] [8.1] [9] [10] [11] [12] [13] [14] [15] [16.0] [16.1] [17] [18]
58-
# CHECK-NEXT: - - - - - 1.50 1.50 - - - - - - - - - - - - - - - -
58+
# CHECK-NEXT: - - - - - 3.00 3.00 - - - - - - - - - - - - - - - -
5959

6060
# CHECK: Resource pressure by instruction:
6161
# CHECK-NEXT: [0.0] [0.1] [1] [2] [3] [4] [5] [6] [7.0] [7.1] [8.0] [8.1] [9] [10] [11] [12] [13] [14] [15] [16.0] [16.1] [17] [18] Instructions:
62-
# CHECK-NEXT: - - - - - 0.50 0.50 - - - - - - - - - - - - - - - - addl %eax, %ecx
63-
# CHECK-NEXT: - - - - - 0.50 0.50 - - - - - - - - - - - - - - - - addl %esi, %eax
64-
# CHECK-NEXT: - - - - - 0.50 0.50 - - - - - - - - - - - - - - - - addl %eax, %edx
62+
# CHECK-NEXT: - - - - - 1.00 1.00 - - - - - - - - - - - - - - - - addl %eax, %ecx
63+
# CHECK-NEXT: - - - - - 1.00 1.00 - - - - - - - - - - - - - - - - addl %esi, %eax
64+
# CHECK-NEXT: - - - - - 1.00 1.00 - - - - - - - - - - - - - - - - addl %eax, %edx
6565

6666
# CHECK: Timeline view:
67-
# CHECK-NEXT: 01234567
68-
# CHECK-NEXT: Index 0123456789
67+
# CHECK-NEXT: 0123456789 01
68+
# CHECK-NEXT: Index 0123456789 0123456789
6969

70-
# CHECK: [0,0] DeER . . . . addl %eax, %ecx
71-
# CHECK-NEXT: [0,1] DeER . . . . addl %esi, %eax
72-
# CHECK-NEXT: [0,2] D=eER. . . . addl %eax, %edx
73-
# CHECK-NEXT: [1,0] D==eER . . . addl %eax, %ecx
74-
# CHECK-NEXT: [1,1] .DeE-R . . . addl %esi, %eax
75-
# CHECK-NEXT: [1,2] .D=eER . . . addl %eax, %edx
76-
# CHECK-NEXT: [2,0] .D==eER . . . addl %eax, %ecx
77-
# CHECK-NEXT: [2,1] .D==eER . . . addl %esi, %eax
78-
# CHECK-NEXT: [2,2] . D==eER . . . addl %eax, %edx
79-
# CHECK-NEXT: [3,0] . D===eER . . . addl %eax, %ecx
80-
# CHECK-NEXT: [3,1] . D==eE-R . . . addl %esi, %eax
81-
# CHECK-NEXT: [3,2] . D===eER . . . addl %eax, %edx
82-
# CHECK-NEXT: [4,0] . D===eER. . . addl %eax, %ecx
83-
# CHECK-NEXT: [4,1] . D===eER. . . addl %esi, %eax
84-
# CHECK-NEXT: [4,2] . D====eER . . addl %eax, %edx
85-
# CHECK-NEXT: [5,0] . D=====eER . . addl %eax, %ecx
86-
# CHECK-NEXT: [5,1] . D===eE-R . . addl %esi, %eax
87-
# CHECK-NEXT: [5,2] . D====eER . . addl %eax, %edx
88-
# CHECK-NEXT: [6,0] . D=====eER . . addl %eax, %ecx
89-
# CHECK-NEXT: [6,1] . D=====eER . . addl %esi, %eax
90-
# CHECK-NEXT: [6,2] . D=====eER . . addl %eax, %edx
91-
# CHECK-NEXT: [7,0] . D======eER. . addl %eax, %ecx
92-
# CHECK-NEXT: [7,1] . D=====eE-R. . addl %esi, %eax
93-
# CHECK-NEXT: [7,2] . D======eER. . addl %eax, %edx
94-
# CHECK-NEXT: [8,0] . .D======eER . addl %eax, %ecx
95-
# CHECK-NEXT: [8,1] . .D======eER . addl %esi, %eax
96-
# CHECK-NEXT: [8,2] . .D=======eER. addl %eax, %edx
97-
# CHECK-NEXT: [9,0] . .D========eER addl %eax, %ecx
98-
# CHECK-NEXT: [9,1] . . D======eE-R addl %esi, %eax
99-
# CHECK-NEXT: [9,2] . . D=======eER addl %eax, %edx
70+
# CHECK: [0,0] DeER . . . . . .. addl %eax, %ecx
71+
# CHECK-NEXT: [0,1] DeER . . . . . .. addl %esi, %eax
72+
# CHECK-NEXT: [0,2] D==eER . . . . .. addl %eax, %edx
73+
# CHECK-NEXT: [1,0] D====eER . . . . .. addl %eax, %ecx
74+
# CHECK-NEXT: [1,1] .D=eE--R . . . . .. addl %esi, %eax
75+
# CHECK-NEXT: [1,2] .D===eER . . . . .. addl %eax, %edx
76+
# CHECK-NEXT: [2,0] .D=====eER. . . . .. addl %eax, %ecx
77+
# CHECK-NEXT: [2,1] .D=====eER. . . . .. addl %esi, %eax
78+
# CHECK-NEXT: [2,2] . D======eER . . . .. addl %eax, %edx
79+
# CHECK-NEXT: [3,0] . D========eER . . . .. addl %eax, %ecx
80+
# CHECK-NEXT: [3,1] . D======eE--R . . . .. addl %esi, %eax
81+
# CHECK-NEXT: [3,2] . D========eER . . . .. addl %eax, %edx
82+
# CHECK-NEXT: [4,0] . D=========eER . . .. addl %eax, %ecx
83+
# CHECK-NEXT: [4,1] . D=========eER . . .. addl %esi, %eax
84+
# CHECK-NEXT: [4,2] . D===========eER . . .. addl %eax, %edx
85+
# CHECK-NEXT: [5,0] . D=============eER. . .. addl %eax, %ecx
86+
# CHECK-NEXT: [5,1] . D==========eE--R. . .. addl %esi, %eax
87+
# CHECK-NEXT: [5,2] . D============eER. . .. addl %eax, %edx
88+
# CHECK-NEXT: [6,0] . D==============eER . .. addl %eax, %ecx
89+
# CHECK-NEXT: [6,1] . D==============eER . .. addl %esi, %eax
90+
# CHECK-NEXT: [6,2] . D===============eER . .. addl %eax, %edx
91+
# CHECK-NEXT: [7,0] . D=================eER .. addl %eax, %ecx
92+
# CHECK-NEXT: [7,1] . D===============eE--R .. addl %esi, %eax
93+
# CHECK-NEXT: [7,2] . D=================eER .. addl %eax, %edx
94+
# CHECK-NEXT: [8,0] . .D==================eER .. addl %eax, %ecx
95+
# CHECK-NEXT: [8,1] . .D==================eER .. addl %esi, %eax
96+
# CHECK-NEXT: [8,2] . .D====================eER.. addl %eax, %edx
97+
# CHECK-NEXT: [9,0] . .D======================eER addl %eax, %ecx
98+
# CHECK-NEXT: [9,1] . . D===================eE--R addl %esi, %eax
99+
# CHECK-NEXT: [9,2] . . D=====================eER addl %eax, %edx
100100

101101
# CHECK: Average Wait times (based on the timeline view):
102102
# CHECK-NEXT: [0]: Executions
@@ -105,6 +105,6 @@ add %eax, %edx
105105
# CHECK-NEXT: [3]: Average time elapsed from WB until retire stage
106106

107107
# CHECK: [0] [1] [2] [3]
108-
# CHECK-NEXT: 0. 10 5.0 0.6 0.0 addl %eax, %ecx
109-
# CHECK-NEXT: 1. 10 4.2 0.5 0.5 addl %esi, %eax
110-
# CHECK-NEXT: 2. 10 5.0 0.0 0.0 addl %eax, %edx
108+
# CHECK-NEXT: 0. 10 12.0 2.0 0.0 addl %eax, %ecx
109+
# CHECK-NEXT: 1. 10 10.7 1.8 1.0 addl %esi, %eax
110+
# CHECK-NEXT: 2. 10 12.5 1.0 0.0 addl %eax, %edx

‎llvm/test/tools/llvm-mca/X86/BdVer2/clear-super-register-1.s

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -15,12 +15,12 @@ bsf %rax, %rcx
1515

1616
# CHECK: Iterations: 100
1717
# CHECK-NEXT: Instructions: 400
18-
# CHECK-NEXT: Total Cycles: 702
18+
# CHECK-NEXT: Total Cycles: 900
1919
# CHECK-NEXT: Total uOps: 1000
2020

2121
# CHECK: Dispatch Width: 4
22-
# CHECK-NEXT: uOps Per Cycle: 1.42
23-
# CHECK-NEXT: IPC: 0.57
22+
# CHECK-NEXT: uOps Per Cycle: 1.11
23+
# CHECK-NEXT: IPC: 0.44
2424
# CHECK-NEXT: Block RThroughput: 4.0
2525

2626
# CHECK: Instruction Info:
@@ -33,22 +33,22 @@ bsf %rax, %rcx
3333

3434
# CHECK: [1] [2] [3] [4] [5] [6] Instructions:
3535
# CHECK-NEXT: 1 6 4.00 imulq $5, %rcx, %rax
36-
# CHECK-NEXT: 2 2 0.50 lzcntl %ecx, %eax
37-
# CHECK-NEXT: 1 1 0.50 andq %rcx, %rax
38-
# CHECK-NEXT: 6 3 2.00 bsfq %rax, %rcx
36+
# CHECK-NEXT: 2 2 2.00 lzcntl %ecx, %eax
37+
# CHECK-NEXT: 1 1 1.00 andq %rcx, %rax
38+
# CHECK-NEXT: 6 3 3.00 bsfq %rax, %rcx
3939

4040
# CHECK: Timeline view:
41-
# CHECK-NEXT: 012345
41+
# CHECK-NEXT: 01234567
4242
# CHECK-NEXT: Index 0123456789
4343

44-
# CHECK: [0,0] DeeeeeeER . . imulq $5, %rcx, %rax
45-
# CHECK-NEXT: [0,1] DeeE----R . . lzcntl %ecx, %eax
46-
# CHECK-NEXT: [0,2] D==eE---R . . andq %rcx, %rax
47-
# CHECK-NEXT: [0,3] .D==eeeER . . bsfq %rax, %rcx
48-
# CHECK-NEXT: [1,0] . D====eeeeeeER. imulq $5, %rcx, %rax
49-
# CHECK-NEXT: [1,1] . D====eeE---R. lzcntl %ecx, %eax
50-
# CHECK-NEXT: [1,2] . D======eE--R. andq %rcx, %rax
51-
# CHECK-NEXT: [1,3] . D======eeeER bsfq %rax, %rcx
44+
# CHECK: [0,0] DeeeeeeER . . . imulq $5, %rcx, %rax
45+
# CHECK-NEXT: [0,1] DeeE----R . . . lzcntl %ecx, %eax
46+
# CHECK-NEXT: [0,2] D==eE---R . . . andq %rcx, %rax
47+
# CHECK-NEXT: [0,3] .D==eeeER . . . bsfq %rax, %rcx
48+
# CHECK-NEXT: [1,0] . D====eeeeeeER. . imulq $5, %rcx, %rax
49+
# CHECK-NEXT: [1,1] . D======eeE-R. . lzcntl %ecx, %eax
50+
# CHECK-NEXT: [1,2] . D========eER. . andq %rcx, %rax
51+
# CHECK-NEXT: [1,3] . D========eeeER bsfq %rax, %rcx
5252

5353
# CHECK: Average Wait times (based on the timeline view):
5454
# CHECK-NEXT: [0]: Executions
@@ -58,6 +58,6 @@ bsf %rax, %rcx
5858

5959
# CHECK: [0] [1] [2] [3]
6060
# CHECK-NEXT: 0. 2 3.0 0.5 0.0 imulq $5, %rcx, %rax
61-
# CHECK-NEXT: 1. 2 3.0 1.0 3.5 lzcntl %ecx, %eax
62-
# CHECK-NEXT: 2. 2 5.0 0.0 2.5 andq %rcx, %rax
63-
# CHECK-NEXT: 3. 2 5.0 0.0 0.0 bsfq %rax, %rcx
61+
# CHECK-NEXT: 1. 2 4.0 2.0 2.5 lzcntl %ecx, %eax
62+
# CHECK-NEXT: 2. 2 6.0 0.0 1.5 andq %rcx, %rax
63+
# CHECK-NEXT: 3. 2 6.0 0.0 0.0 bsfq %rax, %rcx

0 commit comments

Comments
 (0)