add helpful comment that a condition is unreachable

bob80905 · bob80905 · commit 9df037d518b1 · 2024-03-25T13:10:06.000-07:00
diff --git a/clang/lib/Driver/ToolChains/HLSL.cpp b/clang/lib/Driver/ToolChains/HLSL.cpp
@@ -304,6 +304,8 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,
     }
 
     if (!parsedTargetProfile.has_value())
+      // This should be unreachable, target profile validation happens
+      // before this point.
       return DAL;
     else {
       if (parsedTargetProfile.value().Major < 6 ||

Original file line number	Diff line number	Diff line change
`@@ -304,6 +304,8 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch,`
`304`	`304`	`}`
`305`	`305`
`306`	`306`	`if (!parsedTargetProfile.has_value())`
	`307`	`+ // This should be unreachable, target profile validation happens`
	`308`	`+ // before this point.`
`307`	`309`	`return DAL;`
`308`	`310`	`else {`
`309`	`311`	`if (parsedTargetProfile.value().Major < 6 \|\|`