Skip to content

Commit 9f283bf

Browse files
committed
Revert "fix bug that undefined internal is a warning only for -pedantic-errors (#98016)"
This reverts commit e16882f. Broken bots: https://lab.llvm.org/buildbot/#/builders/144/builds/2080
1 parent dd44003 commit 9f283bf

File tree

4 files changed

+1
-43
lines changed

4 files changed

+1
-43
lines changed

clang/docs/ReleaseNotes.rst

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -592,9 +592,6 @@ Attribute Changes in Clang
592592

593593
Improvements to Clang's diagnostics
594594
-----------------------------------
595-
- Clang now emits an error instead of a warning for ``-Wundefined-internal``
596-
when compiling with `-pedantic-errors` to conform to the C standard
597-
598595
- Clang now applies syntax highlighting to the code snippets it
599596
prints.
600597

clang/include/clang/Basic/DiagnosticSemaKinds.td

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6016,7 +6016,7 @@ def note_deleted_assign_field : Note<
60166016
"because field %2 is of %select{reference|const-qualified}4 type %3">;
60176017

60186018
// These should be errors.
6019-
def warn_undefined_internal : ExtWarn<
6019+
def warn_undefined_internal : Warning<
60206020
"%select{function|variable}0 %q1 has internal linkage but is not defined">,
60216021
InGroup<DiagGroup<"undefined-internal">>;
60226022
def err_undefined_internal_type : Error<

clang/test/Sema/undefined-internal-basic.c

Lines changed: 0 additions & 29 deletions
This file was deleted.

clang/test/Sema/undefined-internal-typeof-c23.c

Lines changed: 0 additions & 10 deletions
This file was deleted.

0 commit comments

Comments
 (0)