Final tidy up feedback and run clang-format

Author: Jlalond

lldb/include/lldb/Target/Statistics.h

@@ -182,7 +182,8 @@ struct StatisticsOptions {
 class SummaryStatistics {
 public:
   explicit SummaryStatistics(std::string name, std::string impl_type)
-      : m_total_time(), m_impl_type(std::move(impl_type)), m_name(std::move(name)), m_count(0) {}
+      : m_total_time(), m_impl_type(std::move(impl_type)),
+        m_name(std::move(name)), m_count(0) {}
 
   std::string GetName() const { return m_name; };
   double GetTotalTime() const { return m_total_time.get().count(); }
@@ -237,7 +238,7 @@ class SummaryStatisticsCache {
   GetSummaryStatisticsForProvider(lldb_private::TypeSummaryImpl &provider) {
     std::lock_guard<std::mutex> guard(m_map_mutex);
     if (auto iterator = m_summary_stats_map.find(provider.GetName());
-         iterator != m_summary_stats_map.end())
+        iterator != m_summary_stats_map.end())
       return iterator->second;
 
     auto it = m_summary_stats_map.try_emplace(

lldb/source/DataFormatters/TypeSummary.cpp

@@ -157,7 +157,7 @@ ScriptSummaryFormat::ScriptSummaryFormat(const TypeSummaryImpl::Flags &flags,
                                          const char *python_script)
     : TypeSummaryImpl(Kind::eScript, flags), m_function_name(),
       m_python_script(), m_script_function_sp() {
-  // Take preference in the python script name over the function name.;
+  // Take preference in the python script name over the function name.
   if (function_name) {
     m_function_name.assign(function_name);
     m_script_formatter_name = function_name;
@@ -167,6 +167,8 @@ ScriptSummaryFormat::ScriptSummaryFormat(const TypeSummaryImpl::Flags &flags,
     m_script_formatter_name = python_script;
   }
 
+  // Python scripts include the tabbing of the function def so we remove the
+  // leading spaces.
   m_script_formatter_name = m_script_formatter_name.erase(
       0, m_script_formatter_name.find_first_not_of(' '));
 }

lldb/unittests/Target/SummaryStatisticsTest.cpp

@@ -13,10 +13,9 @@ using Duration = std::chrono::duration<double>;
 
 class DummySummaryImpl : public lldb_private::TypeSummaryImpl {
 public:
-  DummySummaryImpl(Duration sleepTime)
+  DummySummaryImpl()
       : TypeSummaryImpl(TypeSummaryImpl::Kind::eSummaryString,
-                        TypeSummaryImpl::Flags()),
-        m_sleepTime(sleepTime) {}
+                        TypeSummaryImpl::Flags()) {}
 
   std::string GetName() override { return "DummySummary"; }
 
@@ -28,23 +27,18 @@ class DummySummaryImpl : public lldb_private::TypeSummaryImpl {
                     const TypeSummaryOptions &options) override {
     return false;
   }
-
-  void FakeFormat() { std::this_thread::sleep_for(m_sleepTime); }
-
-private:
-  Duration m_sleepTime;
 };
 
 TEST(MultithreadFormatting, Multithread) {
   SummaryStatisticsCache statistics_cache;
-  DummySummaryImpl summary(Duration(1));
+  DummySummaryImpl summary;
   std::vector<std::thread> threads;
   for (int i = 0; i < 10; ++i) {
     threads.emplace_back(std::thread([&statistics_cache, &summary]() {
       auto sp = statistics_cache.GetSummaryStatisticsForProvider(summary);
       {
         SummaryStatistics::SummaryInvocation invocation(sp);
-        summary.FakeFormat();
+        std::this_thread::sleep_for(Duration(1));
       }
     }));
   }