Skip to content

Commit 9faa623

Browse files
authored
[compiler-rt] [test] Work around MS CRT stdio format quirks on mingw too (#93787)
So far, these tests have been disabled in mingw build configurations (built as asan-dynamic), but these were enabled in 246234a, exposing the issue. (That commit is currently reverted, but will probably be relanded in some form soon.)
1 parent c803c29 commit 9faa623

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

compiler-rt/test/asan/TestCases/debug_double_free.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
// FIXME: Doesn't work with DLLs
88
// XFAIL: win32-dynamic-asan
99

10-
// If we use %p with MSVC, it comes out all upper case. Use %08x to get
10+
// If we use %p with MS CRTs, it comes out all upper case. Use %08x to get
1111
// lowercase hex.
12-
#ifdef _MSC_VER
12+
#ifdef _WIN32
1313
# ifdef _WIN64
1414
# define PTR_FMT "0x%08llx"
1515
# else

compiler-rt/test/asan/TestCases/debug_report.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@ int main() {
2222
return 0;
2323
}
2424

25-
// If we use %p with MSVC, it comes out all upper case. Use %08x to get
25+
// If we use %p with MS CRTs, it comes out all upper case. Use %08x to get
2626
// lowercase hex.
27-
#ifdef _MSC_VER
27+
#ifdef _WIN32
2828
# ifdef _WIN64
2929
# define PTR_FMT "0x%08llx"
3030
# else

0 commit comments

Comments
 (0)