Skip to content

Commit a041da3

Browse files
[X86] Use range-based for loops (NFC)
1 parent 0d454d6 commit a041da3

File tree

4 files changed

+11
-14
lines changed

4 files changed

+11
-14
lines changed

llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -263,8 +263,7 @@ class X86AsmParser : public MCTargetAsmParser {
263263
return 0;
264264

265265
SmallVector<ICToken, 16> OperandStack;
266-
for (unsigned i = 0, e = PostfixStack.size(); i != e; ++i) {
267-
ICToken Op = PostfixStack[i];
266+
for (const ICToken &Op : PostfixStack) {
268267
if (Op.first == IC_IMM || Op.first == IC_REGISTER) {
269268
OperandStack.push_back(Op);
270269
} else if (isUnaryOperator(Op.first)) {
@@ -1731,8 +1730,8 @@ bool X86AsmParser::VerifyAndAdjustOperands(OperandVector &OrigOperands,
17311730
OrigOperands.pop_back();
17321731
}
17331732
// OrigOperands.append(FinalOperands.begin(), FinalOperands.end());
1734-
for (unsigned int i = 0; i < FinalOperands.size(); ++i)
1735-
OrigOperands.push_back(std::move(FinalOperands[i]));
1733+
for (auto &Op : FinalOperands)
1734+
OrigOperands.push_back(std::move(Op));
17361735

17371736
return false;
17381737
}

llvm/lib/Target/X86/X86FastISel.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1306,8 +1306,8 @@ bool X86FastISel::X86SelectRet(const Instruction *I) {
13061306
MIB = BuildMI(*FuncInfo.MBB, FuncInfo.InsertPt, MIMD,
13071307
TII.get(Subtarget->is64Bit() ? X86::RET64 : X86::RET32));
13081308
}
1309-
for (unsigned i = 0, e = RetRegs.size(); i != e; ++i)
1310-
MIB.addReg(RetRegs[i], RegState::Implicit);
1309+
for (unsigned Reg : RetRegs)
1310+
MIB.addReg(Reg, RegState::Implicit);
13111311
return true;
13121312
}
13131313

@@ -3346,8 +3346,7 @@ bool X86FastISel::fastLowerCall(CallLoweringInfo &CLI) {
33463346

33473347
// Walk the register/memloc assignments, inserting copies/loads.
33483348
const X86RegisterInfo *RegInfo = Subtarget->getRegisterInfo();
3349-
for (unsigned i = 0, e = ArgLocs.size(); i != e; ++i) {
3350-
CCValAssign const &VA = ArgLocs[i];
3349+
for (const CCValAssign &VA : ArgLocs) {
33513350
const Value *ArgVal = OutVals[VA.getValNo()];
33523351
MVT ArgVT = OutVTs[VA.getValNo()];
33533352

llvm/lib/Target/X86/X86FloatingPoint.cpp

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -462,8 +462,7 @@ bool FPS::processBasicBlock(MachineFunction &MF, MachineBasicBlock &BB) {
462462

463463
// Check to see if any of the values defined by this instruction are dead
464464
// after definition. If so, pop them.
465-
for (unsigned i = 0, e = DeadRegs.size(); i != e; ++i) {
466-
unsigned Reg = DeadRegs[i];
465+
for (unsigned Reg : DeadRegs) {
467466
// Check if Reg is live on the stack. An inline-asm register operand that
468467
// is in the clobber list and marked dead might not be live on the stack.
469468
static_assert(X86::FP7 - X86::FP0 == 7, "sequential FP regnumbers");

llvm/lib/Target/X86/X86InstrInfo.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8263,8 +8263,8 @@ bool X86InstrInfo::unfoldMemoryOperand(
82638263

82648264
DebugLoc DL;
82658265
MachineInstrBuilder MIB = BuildMI(MF, DL, get(Opc), Reg);
8266-
for (unsigned i = 0, e = AddrOps.size(); i != e; ++i)
8267-
MIB.add(AddrOps[i]);
8266+
for (const MachineOperand &AddrOp : AddrOps)
8267+
MIB.add(AddrOp);
82688268
MIB.setMemRefs(MMOs);
82698269
NewMIs.push_back(MIB);
82708270

@@ -8341,8 +8341,8 @@ bool X86InstrInfo::unfoldMemoryOperand(
83418341
unsigned Opc = getStoreRegOpcode(Reg, DstRC, isAligned, Subtarget);
83428342
DebugLoc DL;
83438343
MachineInstrBuilder MIB = BuildMI(MF, DL, get(Opc));
8344-
for (unsigned i = 0, e = AddrOps.size(); i != e; ++i)
8345-
MIB.add(AddrOps[i]);
8344+
for (const MachineOperand &AddrOp : AddrOps)
8345+
MIB.add(AddrOp);
83468346
MIB.addReg(Reg, RegState::Kill);
83478347
MIB.setMemRefs(MMOs);
83488348
NewMIs.push_back(MIB);

0 commit comments

Comments
 (0)