Skip to content

Commit a0d03ad

Browse files
committed
Add TODOs
1 parent 94ab68b commit a0d03ad

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

clang/include/clang/Serialization/ModuleCache.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,10 @@ class ModuleCache : public RefCountedBase<ModuleCache> {
3333
virtual std::unique_ptr<llvm::AdvisoryLock>
3434
getLock(StringRef ModuleFilename) = 0;
3535

36+
// TODO: Abstract away timestamps with isUpToDate() and markUpToDate().
37+
// TODO: Consider exposing a "validation lock" API to prevent multiple clients
38+
// concurrently noticing an out-of-date module file and validating its inputs.
39+
3640
/// Returns the timestamp denoting the last time inputs of the module file
3741
/// were validated.
3842
virtual std::time_t getModuleTimestamp(StringRef ModuleFilename) = 0;

0 commit comments

Comments
 (0)