Skip to content

Commit a1028b0

Browse files
author
Francis Visoiu Mistrih
committed
[RISCV] Add scheduling info for Zcmp
The order of the entries in the list is: outs, Defs, implicit-defs, ins, Uses, implicit uses, where the implicit ones are added programatically during codegen depending on the registers saved/restored and are not described in the TD files. This also fixes CM_MVSA01's Defs/Uses list.
1 parent c1e9883 commit a1028b0

File tree

2 files changed

+38
-7
lines changed

2 files changed

+38
-7
lines changed

llvm/lib/Target/RISCV/RISCVInstrInfoZc.td

Lines changed: 25 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -181,29 +181,47 @@ def C_SH : CStoreH_rri<0b100011, 0b0, "c.sh">,
181181

182182
// Zcmp
183183
let DecoderNamespace = "RVZcmp", Predicates = [HasStdExtZcmp],
184-
Defs = [X10, X11], hasSideEffects = 0, mayLoad = 0, mayStore = 0 in {
184+
hasSideEffects = 0, mayLoad = 0, mayStore = 0 in {
185+
let Defs = [X10, X11] in
185186
def CM_MVA01S : RVInst16CA<0b101011, 0b11, 0b10, (outs),
186-
(ins SR07:$rs1, SR07:$rs2), "cm.mva01s", "$rs1, $rs2">;
187+
(ins SR07:$rs1, SR07:$rs2), "cm.mva01s", "$rs1, $rs2">,
188+
Sched<[WriteIALU, WriteIALU, ReadIALU, ReadIALU]>;
187189

190+
let Uses = [X10, X11] in
188191
def CM_MVSA01 : RVInst16CA<0b101011, 0b01, 0b10, (outs SR07:$rs1, SR07:$rs2),
189-
(ins), "cm.mvsa01", "$rs1, $rs2">;
192+
(ins), "cm.mvsa01", "$rs1, $rs2">,
193+
Sched<[WriteIALU, WriteIALU, ReadIALU, ReadIALU]>;
190194
} // DecoderNamespace = "RVZcmp", Predicates = [HasStdExtZcmp]...
191195

192196
let DecoderNamespace = "RVZcmp", Predicates = [HasStdExtZcmp] in {
193197
let hasSideEffects = 0, mayLoad = 0, mayStore = 1, Uses = [X2], Defs = [X2] in
194-
def CM_PUSH : RVInstZcCPPP<0b11000, "cm.push">;
198+
def CM_PUSH : RVInstZcCPPP<0b11000, "cm.push">,
199+
Sched<[WriteIALU, ReadIALU, ReadStoreData, ReadStoreData,
200+
ReadStoreData, ReadStoreData, ReadStoreData, ReadStoreData,
201+
ReadStoreData, ReadStoreData, ReadStoreData, ReadStoreData,
202+
ReadStoreData, ReadStoreData, ReadStoreData]>;
195203

196204
let hasSideEffects = 0, mayLoad = 1, mayStore = 0, isReturn = 1,
197205
Uses = [X2], Defs = [X2] in
198-
def CM_POPRET : RVInstZcCPPP<0b11110, "cm.popret">;
206+
def CM_POPRET : RVInstZcCPPP<0b11110, "cm.popret">,
207+
Sched<[WriteIALU, WriteLDW, WriteLDW, WriteLDW, WriteLDW,
208+
WriteLDW, WriteLDW, WriteLDW, WriteLDW, WriteLDW,
209+
WriteLDW, WriteLDW, WriteLDW, WriteLDW, ReadIALU]>;
199210

200211
let hasSideEffects = 0, mayLoad = 1, mayStore = 0, isReturn = 1,
201212
Uses = [X2], Defs = [X2, X10] in
202-
def CM_POPRETZ : RVInstZcCPPP<0b11100, "cm.popretz">;
213+
def CM_POPRETZ : RVInstZcCPPP<0b11100, "cm.popretz">,
214+
Sched<[WriteIALU, WriteIALU, WriteLDW, WriteLDW, WriteLDW,
215+
WriteLDW, WriteLDW, WriteLDW, WriteLDW, WriteLDW,
216+
WriteLDW, WriteLDW, WriteLDW, WriteLDW, WriteLDW,
217+
ReadIALU]>;
203218

204219
let hasSideEffects = 0, mayLoad = 1, mayStore = 0,
205220
Uses = [X2], Defs = [X2] in
206-
def CM_POP : RVInstZcCPPP<0b11010, "cm.pop">;
221+
def CM_POP : RVInstZcCPPP<0b11010, "cm.pop">,
222+
Sched<[WriteIALU, WriteLDW, WriteLDW, WriteLDW, WriteLDW,
223+
WriteLDW, WriteLDW, WriteLDW, WriteLDW, WriteLDW, WriteLDW,
224+
WriteLDW, WriteLDW, WriteLDW, ReadIALU]>;
207225
} // DecoderNamespace = "RVZcmp", Predicates = [HasStdExtZcmp]...
208226

209227
let DecoderNamespace = "RVZcmt", Predicates = [HasStdExtZcmt],

llvm/test/CodeGen/RISCV/cm_mvas_mvsa.ll

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,9 @@
33
; RUN: | FileCheck -check-prefixes=CHECK32I %s
44
; RUN: llc -mtriple=riscv32 -mattr=+zcmp -verify-machineinstrs < %s \
55
; RUN: | FileCheck -check-prefixes=CHECK32ZCMP %s
6+
; RUN: llc -mtriple=riscv32 -mattr=+zcmp -verify-machineinstrs \
7+
; RUN: -stop-after=riscv-move-merge < %s \
8+
; RUN: | FileCheck -check-prefixes=CHECK32ZCMPMIR %s
69
; RUN: llc -mtriple=riscv64 -verify-machineinstrs < %s \
710
; RUN: | FileCheck -check-prefixes=CHECK64I %s
811
; RUN: llc -mtriple=riscv64 -mattr=+zcmp -verify-machineinstrs < %s \
@@ -77,6 +80,7 @@ define i32 @zcmp_mv(i32 %num, i32 %f) nounwind {
7780
; CHECK64ZCMP-NEXT: call func
7881
; CHECK64ZCMP-NEXT: addw a0, s2, s0
7982
; CHECK64ZCMP-NEXT: cm.popret {ra, s0-s2}, 32
83+
8084
%call = call i32 @func(i32 %num, i32 %f)
8185
%call1 = call i32 @func(i32 %num, i32 %f)
8286
%res = add i32 %call, %f
@@ -163,3 +167,12 @@ define i32 @not_zcmp_mv(i32 %num, i32 %f) nounwind {
163167
%res = call i32 @func(i32 1, i32 %f)
164168
ret i32 %res
165169
}
170+
171+
; CHECK32ZCMPMIR-LABEL: name: zcmp_mv
172+
; CHECK32ZCMPMIR: $x9, $x8 = CM_MVSA01 implicit-def $x10, implicit-def $x11
173+
; CHECK32ZCMPMIR: CM_MVA01S killed $x9, $x8, implicit-def $x10, implicit-def $x11
174+
; CHECK32ZCMPMIR-LABEL: name: not_zcmp_mv
175+
; CHECK32ZCMPMIR-NOT: CM_MVSA01
176+
; CHECK32ZCMPMIR-NOT: CM_MVA01S
177+
;; NOTE: These prefixes are unused and the list is autogenerated. Do not add tests below this line:
178+
; CHECK32ZCMPMIR: {{.*}}

0 commit comments

Comments
 (0)