[SlotIndexes] Simplify getInstructionFromIndex. NFCI.

jayfoad · jayfoad · commit a12e747c4c6d · 2023-10-11T16:38:59.000+01:00
This method should never be called on an invalid index.
diff --git a/llvm/include/llvm/CodeGen/SlotIndexes.h b/llvm/include/llvm/CodeGen/SlotIndexes.h
@@ -387,7 +387,7 @@ class raw_ostream;
     /// Returns the instruction for the given index, or null if the given
     /// index has no instruction associated with it.
     MachineInstr* getInstructionFromIndex(SlotIndex index) const {
-      return index.isValid() ? index.listEntry()->getInstr() : nullptr;
+      return index.listEntry()->getInstr();
     }
 
     /// Returns the next non-null index, if one exists.

Original file line number	Diff line number	Diff line change
`@@ -387,7 +387,7 @@ class raw_ostream;`
`387`	`387`	`/// Returns the instruction for the given index, or null if the given`
`388`	`388`	`/// index has no instruction associated with it.`
`389`	`389`	`MachineInstr* getInstructionFromIndex(SlotIndex index) const {`
`390`		`- return index.isValid() ? index.listEntry()->getInstr() : nullptr;`
	`390`	`+ return index.listEntry()->getInstr();`
`391`	`391`	`}`
`392`	`392`
`393`	`393`	`/// Returns the next non-null index, if one exists.`