Skip to content

Commit a21c31e

Browse files
committed
fixup! [RISCV] RISCV vector calling convention (1/2)
1 parent 66b04d6 commit a21c31e

File tree

7 files changed

+43
-36
lines changed

7 files changed

+43
-36
lines changed

clang/include/clang/Basic/Specifiers.h

Lines changed: 22 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -273,30 +273,30 @@ namespace clang {
273273

274274
/// CallingConv - Specifies the calling convention that a function uses.
275275
enum CallingConv {
276-
CC_C, // __attribute__((cdecl))
277-
CC_X86StdCall, // __attribute__((stdcall))
278-
CC_X86FastCall, // __attribute__((fastcall))
279-
CC_X86ThisCall, // __attribute__((thiscall))
280-
CC_X86VectorCall, // __attribute__((vectorcall))
281-
CC_X86Pascal, // __attribute__((pascal))
282-
CC_Win64, // __attribute__((ms_abi))
283-
CC_X86_64SysV, // __attribute__((sysv_abi))
284-
CC_X86RegCall, // __attribute__((regcall))
285-
CC_AAPCS, // __attribute__((pcs("aapcs")))
286-
CC_AAPCS_VFP, // __attribute__((pcs("aapcs-vfp")))
287-
CC_IntelOclBicc, // __attribute__((intel_ocl_bicc))
288-
CC_SpirFunction, // default for OpenCL functions on SPIR target
289-
CC_OpenCLKernel, // inferred for OpenCL kernels
290-
CC_Swift, // __attribute__((swiftcall))
276+
CC_C, // __attribute__((cdecl))
277+
CC_X86StdCall, // __attribute__((stdcall))
278+
CC_X86FastCall, // __attribute__((fastcall))
279+
CC_X86ThisCall, // __attribute__((thiscall))
280+
CC_X86VectorCall, // __attribute__((vectorcall))
281+
CC_X86Pascal, // __attribute__((pascal))
282+
CC_Win64, // __attribute__((ms_abi))
283+
CC_X86_64SysV, // __attribute__((sysv_abi))
284+
CC_X86RegCall, // __attribute__((regcall))
285+
CC_AAPCS, // __attribute__((pcs("aapcs")))
286+
CC_AAPCS_VFP, // __attribute__((pcs("aapcs-vfp")))
287+
CC_IntelOclBicc, // __attribute__((intel_ocl_bicc))
288+
CC_SpirFunction, // default for OpenCL functions on SPIR target
289+
CC_OpenCLKernel, // inferred for OpenCL kernels
290+
CC_Swift, // __attribute__((swiftcall))
291291
CC_SwiftAsync, // __attribute__((swiftasynccall))
292-
CC_PreserveMost, // __attribute__((preserve_most))
293-
CC_PreserveAll, // __attribute__((preserve_all))
292+
CC_PreserveMost, // __attribute__((preserve_most))
293+
CC_PreserveAll, // __attribute__((preserve_all))
294294
CC_AArch64VectorCall, // __attribute__((aarch64_vector_pcs))
295-
CC_AArch64SVEPCS, // __attribute__((aarch64_sve_pcs))
296-
CC_AMDGPUKernelCall, // __attribute__((amdgpu_kernel))
297-
CC_M68kRTD, // __attribute__((m68k_rtd))
298-
CC_PreserveNone, // __attribute__((preserve_none))
299-
CC_RISCVVectorCall, // __attribute__((riscv_vector_cc))
295+
CC_AArch64SVEPCS, // __attribute__((aarch64_sve_pcs))
296+
CC_AMDGPUKernelCall, // __attribute__((amdgpu_kernel))
297+
CC_M68kRTD, // __attribute__((m68k_rtd))
298+
CC_PreserveNone, // __attribute__((preserve_none))
299+
CC_RISCVVectorCall, // __attribute__((riscv_vector_cc))
300300
};
301301

302302
/// Checks whether the given calling convention supports variadic

clang/lib/AST/Type.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3439,7 +3439,8 @@ StringRef FunctionType::getNameForCallConv(CallingConv CC) {
34393439
case CC_PreserveAll: return "preserve_all";
34403440
case CC_M68kRTD: return "m68k_rtd";
34413441
case CC_PreserveNone: return "preserve_none";
3442-
case CC_RISCVVectorCall: return "riscv_vector_cc";
3442+
case CC_RISCVVectorCall:
3443+
return "riscv_vector_cc";
34433444
}
34443445

34453446
llvm_unreachable("Invalid calling convention.");

clang/lib/Basic/Targets/RISCV.cpp

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -471,10 +471,10 @@ ParsedTargetAttr RISCVTargetInfo::parseTargetAttr(StringRef Features) const {
471471
TargetInfo::CallingConvCheckResult
472472
RISCVTargetInfo::checkCallingConvention(CallingConv CC) const {
473473
switch (CC) {
474-
default:
475-
return CCCR_Warning;
476-
case CC_C:
477-
case CC_RISCVVectorCall:
478-
return CCCR_OK;
474+
default:
475+
return CCCR_Warning;
476+
case CC_C:
477+
case CC_RISCVVectorCall:
478+
return CCCR_OK;
479479
}
480480
}

clang/lib/CodeGen/CGCall.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -74,7 +74,8 @@ unsigned CodeGenTypes::ClangCallConvToLLVMCallConv(CallingConv CC) {
7474
case CC_SwiftAsync: return llvm::CallingConv::SwiftTail;
7575
case CC_M68kRTD: return llvm::CallingConv::M68k_RTD;
7676
case CC_PreserveNone: return llvm::CallingConv::PreserveNone;
77-
case CC_RISCVVectorCall: return llvm::CallingConv::RISCV_VectorCall;
77+
case CC_RISCVVectorCall:
78+
return llvm::CallingConv::RISCV_VectorCall;
7879
}
7980
}
8081

llvm/lib/AsmParser/LLParser.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2201,7 +2201,9 @@ bool LLParser::parseOptionalCallingConv(unsigned &CC) {
22012201
case lltok::kw_tailcc: CC = CallingConv::Tail; break;
22022202
case lltok::kw_m68k_rtdcc: CC = CallingConv::M68k_RTD; break;
22032203
case lltok::kw_graalcc: CC = CallingConv::GRAAL; break;
2204-
case lltok::kw_riscv_vector_cc:CC = CallingConv::RISCV_VectorCall; break;
2204+
case lltok::kw_riscv_vector_cc:
2205+
CC = CallingConv::RISCV_VectorCall;
2206+
break;
22052207
case lltok::kw_cc: {
22062208
Lex.Lex();
22072209
return parseUInt32(CC);

llvm/lib/IR/AsmWriter.cpp

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -363,7 +363,9 @@ static void PrintCallingConv(unsigned cc, raw_ostream &Out) {
363363
case CallingConv::AMDGPU_KERNEL: Out << "amdgpu_kernel"; break;
364364
case CallingConv::AMDGPU_Gfx: Out << "amdgpu_gfx"; break;
365365
case CallingConv::M68k_RTD: Out << "m68k_rtdcc"; break;
366-
case CallingConv::RISCV_VectorCall: Out << "riscv_vector_cc"; break;
366+
case CallingConv::RISCV_VectorCall:
367+
Out << "riscv_vector_cc";
368+
break;
367369
}
368370
}
369371

llvm/lib/Target/RISCV/RISCVFrameLowering.cpp

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1565,12 +1565,12 @@ bool RISCVFrameLowering::spillCalleeSavedRegisters(
15651565
const auto &RVVCSI = getRVVCalleeSavedInfo(*MF, CSI);
15661566

15671567
auto storeRegToStackSlot = [&](decltype(UnmanagedCSI) CSInfo) {
1568-
for (auto &CS: CSInfo) {
1568+
for (auto &CS : CSInfo) {
15691569
// Insert the spill to the stack frame.
15701570
Register Reg = CS.getReg();
15711571
const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg);
1572-
TII.storeRegToStackSlot(MBB, MI, Reg, !MBB.isLiveIn(Reg), CS.getFrameIdx(),
1573-
RC, TRI, Register());
1572+
TII.storeRegToStackSlot(MBB, MI, Reg, !MBB.isLiveIn(Reg),
1573+
CS.getFrameIdx(), RC, TRI, Register());
15741574
}
15751575
};
15761576
storeRegToStackSlot(UnmanagedCSI);
@@ -1658,12 +1658,13 @@ bool RISCVFrameLowering::restoreCalleeSavedRegisters(
16581658
const auto &RVVCSI = getRVVCalleeSavedInfo(*MF, CSI);
16591659

16601660
auto loadRegFromStackSlot = [&](decltype(UnmanagedCSI) CSInfo) {
1661-
for (auto &CS: CSInfo) {
1661+
for (auto &CS : CSInfo) {
16621662
Register Reg = CS.getReg();
16631663
const TargetRegisterClass *RC = TRI->getMinimalPhysRegClass(Reg);
16641664
TII.loadRegFromStackSlot(MBB, MI, Reg, CS.getFrameIdx(), RC, TRI,
16651665
Register());
1666-
assert(MI != MBB.begin() && "loadRegFromStackSlot didn't insert any code!");
1666+
assert(MI != MBB.begin() &&
1667+
"loadRegFromStackSlot didn't insert any code!");
16671668
}
16681669
};
16691670
loadRegFromStackSlot(RVVCSI);

0 commit comments

Comments
 (0)