Revert "Remove redundant check discovered in post-commit review of r209505."

djasper-gh · djasper-gh · commit a2332425c4bd · 2014-05-30T13:31:14.000Z
This breaks with MSVC.
With IsLateTemplateParsed, FunctionDecl::doesThisDeclarationHaveABody() returns true regardless of Body.

This reinstates what was fixed in r208985.

llvm-svn: 209896
diff --git a/clang-tools-extra/clang-tidy/misc/UseOverride.cpp b/clang-tools-extra/clang-tidy/misc/UseOverride.cpp
@@ -96,8 +96,10 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) {
       }
     }
 
-    if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody())
+    if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody() &&
+        Method->getBody()) {
       InsertLoc = Method->getBody()->getLocStart();
+    }
 
     if (!InsertLoc.isValid()) {
       if (Tokens.size() > 2 && GetText(Tokens.back(), Sources) == "0" &&

Original file line number	Diff line number	Diff line change
`@@ -96,8 +96,10 @@ void UseOverride::check(const MatchFinder::MatchResult &Result) {`
`96`	`96`	`}`
`97`	`97`	`}`
`98`	`98`
`99`		`- if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody())`
	`99`	`+ if (InsertLoc.isInvalid() && Method->doesThisDeclarationHaveABody() &&`
	`100`	`+ Method->getBody()) {`
`100`	`101`	`InsertLoc = Method->getBody()->getLocStart();`
	`102`	`+ }`
`101`	`103`
`102`	`104`	`if (!InsertLoc.isValid()) {`
`103`	`105`	`if (Tokens.size() > 2 && GetText(Tokens.back(), Sources) == "0" &&`