Skip to content

Commit a28e4ea

Browse files
authored
[libc] Default to a single threaded thread pool for GPU tests (#74486)
Summary: The GPU tests tend to fail when run massively in parallel. This is why we use a CMake job pool to limit it to 1 in most cases. We should default to the configuration that is most likely to work, that being a single thread. There aren't enough GPU tests for this to be a massive increase in test time on the bots, so we should default to what works guaranteed.
1 parent bbd1941 commit a28e4ea

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

libc/cmake/modules/prepare_libc_gpu_build.cmake

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ set(LIBC_GPU_TEST_JOBS "" CACHE STRING "Number of jobs to use for GPU tests")
7878
if(LIBC_GPU_TEST_JOBS)
7979
set_property(GLOBAL PROPERTY JOB_POOLS LIBC_GPU_TEST_POOL=${LIBC_GPU_TEST_JOBS})
8080
set(LIBC_HERMETIC_TEST_JOB_POOL JOB_POOL LIBC_GPU_TEST_POOL)
81+
else()
82+
set_property(GLOBAL PROPERTY JOB_POOLS LIBC_GPU_TEST_POOL=1)
83+
set(LIBC_HERMETIC_TEST_JOB_POOL JOB_POOL LIBC_GPU_TEST_POOL)
8184
endif()
8285

8386
set(LIBC_GPU_TEST_ARCHITECTURE "" CACHE STRING "Architecture for the GPU tests")

0 commit comments

Comments
 (0)