[clangd] Remove UB introduced in rL341057

kirillbobyrev · kirillbobyrev · commit a2f146fd9cf5 · 2018-08-30T13:30:34.000Z
llvm-svn: 341066
diff --git a/clang-tools-extra/clangd/index/dex/Iterator.cpp b/clang-tools-extra/clangd/index/dex/Iterator.cpp
@@ -193,7 +193,6 @@ class OrIterator : public Iterator {
   OrIterator(std::vector<std::unique_ptr<Iterator>> AllChildren)
       : Children(std::move(AllChildren)) {
     assert(Children.size() > 0 && "Or Iterator must have at least one child.");
-    std::sort(begin(Children), end(Children));
   }
 
   /// Returns true if all children are exhausted.

Original file line number	Diff line number	Diff line change
`@@ -193,7 +193,6 @@ class OrIterator : public Iterator {`
`193`	`193`	`OrIterator(std::vector<std::unique_ptr<Iterator>> AllChildren)`
`194`	`194`	`: Children(std::move(AllChildren)) {`
`195`	`195`	`assert(Children.size() > 0 && "Or Iterator must have at least one child.");`
`196`		`- std::sort(begin(Children), end(Children));`
`197`	`196`	`}`
`198`	`197`
`199`	`198`	`/// Returns true if all children are exhausted.`