Skip to content

Commit a36faa4

Browse files
committed
Address more code review feedback.
1 parent 61f2abd commit a36faa4

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

llvm/lib/Target/SPIRV/SPIRVModuleAnalysis.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -144,8 +144,8 @@ void SPIRVModuleAnalysis::setBaseInfo(const Module &M) {
144144
static_cast<SPIRV::MemoryModel::MemoryModel>(getMetadataUInt(MemMD, 1));
145145
} else {
146146
// TODO: Add support for VulkanMemoryModel.
147-
MAI.Mem = !ST->isShaderEnv() ? SPIRV::MemoryModel::OpenCL
148-
: SPIRV::MemoryModel::GLSL450;
147+
MAI.Mem = ST->isShaderEnv() ? SPIRV::MemoryModel::GLSL450
148+
: SPIRV::MemoryModel::OpenCL;
149149
if (MAI.Mem == SPIRV::MemoryModel::OpenCL) {
150150
unsigned PtrSize = ST->getPointerSize();
151151
MAI.Addr = PtrSize == 32 ? SPIRV::AddressingModel::Physical32

llvm/lib/Target/SPIRV/SPIRVSubtarget.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -119,10 +119,10 @@ bool SPIRVSubtarget::canUseExtInstSet(
119119

120120
SPIRV::InstructionSet::InstructionSet
121121
SPIRVSubtarget::getPreferredInstructionSet() const {
122-
if (!isShaderEnv())
123-
return SPIRV::InstructionSet::OpenCL_std;
124-
else
122+
if (isShaderEnv())
125123
return SPIRV::InstructionSet::GLSL_std_450;
124+
else
125+
return SPIRV::InstructionSet::OpenCL_std;
126126
}
127127

128128
bool SPIRVSubtarget::isAtLeastSPIRVVer(VersionTuple VerToCompareTo) const {

0 commit comments

Comments
 (0)