Skip to content

Commit a370808

Browse files
author
Bharadwaj Yadavalli
committed
Delete redundant calls to normalize TargetOpts Triple as it is already normalized
as pointed out in PR feedback.
1 parent ceaf226 commit a370808

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

clang/lib/Frontend/CompilerInvocation.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -587,8 +587,7 @@ static bool FixupInvocation(CompilerInvocation &Invocation,
587587
LangOpts.SpeculativeLoadHardening = CodeGenOpts.SpeculativeLoadHardening;
588588
LangOpts.CurrentModule = LangOpts.ModuleName;
589589

590-
llvm::Triple T(llvm::Triple::normalize(TargetOpts.Triple));
591-
590+
llvm::Triple T(TargetOpts.Triple);
592591
llvm::Triple::ArchType Arch = T.getArch();
593592

594593
CodeGenOpts.CodeModel = TargetOpts.CodeModel;
@@ -4676,7 +4675,7 @@ bool CompilerInvocation::CreateFromArgsImpl(
46764675
// FIXME: We shouldn't have to pass the DashX option around here
46774676
InputKind DashX = Res.getFrontendOpts().DashX;
46784677
ParseTargetArgs(Res.getTargetOpts(), Args, Diags);
4679-
llvm::Triple T(llvm::Triple::normalize(Res.getTargetOpts().Triple));
4678+
llvm::Triple T(Res.getTargetOpts().Triple);
46804679
ParseHeaderSearchArgs(Res.getHeaderSearchOpts(), Args, Diags,
46814680
Res.getFileSystemOpts().WorkingDir);
46824681
ParseAPINotesArgs(Res.getAPINotesOpts(), Args, Diags);
@@ -4902,7 +4901,7 @@ std::string CompilerInvocation::getModuleHash() const {
49024901

49034902
void CompilerInvocationBase::generateCC1CommandLine(
49044903
ArgumentConsumer Consumer) const {
4905-
llvm::Triple T(llvm::Triple::normalize(getTargetOpts().Triple));
4904+
llvm::Triple T(getTargetOpts().Triple);
49064905

49074906
GenerateFileSystemArgs(getFileSystemOpts(), Consumer);
49084907
GenerateMigratorArgs(getMigratorOpts(), Consumer);

0 commit comments

Comments
 (0)