Skip to content

Commit a3ef858

Browse files
committed
[mlir,polly] Replace uses of IRBuilder::getInt8PtrTy with getPtrTy. NFC
1 parent 0407248 commit a3ef858

File tree

6 files changed

+20
-23
lines changed

6 files changed

+20
-23
lines changed

mlir/lib/ExecutionEngine/ExecutionEngine.cpp

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -175,9 +175,8 @@ static void packFunctionArguments(Module *module) {
175175
llvm::Value *argIndex = llvm::Constant::getIntegerValue(
176176
builder.getInt64Ty(), APInt(64, index));
177177
llvm::Value *argPtrPtr =
178-
builder.CreateGEP(builder.getInt8PtrTy(), argList, argIndex);
179-
llvm::Value *argPtr =
180-
builder.CreateLoad(builder.getInt8PtrTy(), argPtrPtr);
178+
builder.CreateGEP(builder.getPtrTy(), argList, argIndex);
179+
llvm::Value *argPtr = builder.CreateLoad(builder.getPtrTy(), argPtrPtr);
181180
llvm::Type *argTy = arg.getType();
182181
llvm::Value *load = builder.CreateLoad(argTy, argPtr);
183182
args.push_back(load);
@@ -191,9 +190,8 @@ static void packFunctionArguments(Module *module) {
191190
llvm::Value *retIndex = llvm::Constant::getIntegerValue(
192191
builder.getInt64Ty(), APInt(64, llvm::size(func.args())));
193192
llvm::Value *retPtrPtr =
194-
builder.CreateGEP(builder.getInt8PtrTy(), argList, retIndex);
195-
llvm::Value *retPtr =
196-
builder.CreateLoad(builder.getInt8PtrTy(), retPtrPtr);
193+
builder.CreateGEP(builder.getPtrTy(), argList, retIndex);
194+
llvm::Value *retPtr = builder.CreateLoad(builder.getPtrTy(), retPtrPtr);
197195
builder.CreateStore(result, retPtr);
198196
}
199197

mlir/lib/Target/LLVMIR/Dialect/OpenMP/OpenMPToLLVMIRTranslation.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2286,11 +2286,11 @@ createAlteredByCaptureMap(MapInfoData &mapData,
22862286
auto curInsert = builder.saveIP();
22872287
builder.restoreIP(findAllocaInsertPoint(builder, moduleTranslation));
22882288
auto *memTempAlloc =
2289-
builder.CreateAlloca(builder.getInt8PtrTy(), nullptr, ".casted");
2289+
builder.CreateAlloca(builder.getPtrTy(), nullptr, ".casted");
22902290
builder.restoreIP(curInsert);
22912291

22922292
builder.CreateStore(newV, memTempAlloc);
2293-
newV = builder.CreateLoad(builder.getInt8PtrTy(), memTempAlloc);
2293+
newV = builder.CreateLoad(builder.getPtrTy(), memTempAlloc);
22942294
}
22952295

22962296
mapData.Pointers[i] = newV;

polly/lib/CodeGen/LoopGeneratorsGOMP.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ void ParallelLoopGeneratorGOMP::createCallSpawnThreads(Value *SubFn,
3030
GlobalValue::LinkageTypes Linkage = Function::ExternalLinkage;
3131

3232
Type *Params[] = {PointerType::getUnqual(FunctionType::get(
33-
Builder.getVoidTy(), Builder.getInt8PtrTy(), false)),
34-
Builder.getInt8PtrTy(),
33+
Builder.getVoidTy(), Builder.getPtrTy(), false)),
34+
Builder.getPtrTy(),
3535
Builder.getInt32Ty(),
3636
LongType,
3737
LongType,
@@ -61,7 +61,7 @@ void ParallelLoopGeneratorGOMP::deployParallelExecution(Function *SubFn,
6161

6262
Function *ParallelLoopGeneratorGOMP::prepareSubFnDefinition(Function *F) const {
6363
FunctionType *FT =
64-
FunctionType::get(Builder.getVoidTy(), {Builder.getInt8PtrTy()}, false);
64+
FunctionType::get(Builder.getVoidTy(), {Builder.getPtrTy()}, false);
6565
Function *SubFn = Function::Create(FT, Function::InternalLinkage,
6666
F->getName() + "_polly_subfn", M);
6767
// Name the function's arguments

polly/lib/CodeGen/LoopGeneratorsKMP.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Function *ParallelLoopGeneratorKMP::prepareSubFnDefinition(Function *F) const {
8181
LongType,
8282
LongType,
8383
LongType,
84-
Builder.getInt8PtrTy()};
84+
Builder.getPtrTy()};
8585

8686
FunctionType *FT = FunctionType::get(Builder.getVoidTy(), Arguments, false);
8787
Function *SubFn = Function::Create(FT, Function::InternalLinkage,
@@ -512,7 +512,7 @@ GlobalVariable *ParallelLoopGeneratorKMP::createSourceLocation() {
512512
if (!IdentTy) {
513513
Type *LocMembers[] = {Builder.getInt32Ty(), Builder.getInt32Ty(),
514514
Builder.getInt32Ty(), Builder.getInt32Ty(),
515-
Builder.getInt8PtrTy()};
515+
Builder.getPtrTy()};
516516

517517
IdentTy =
518518
StructType::create(M->getContext(), LocMembers, StructName, false);

polly/lib/CodeGen/PerfMonitor.cpp

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ Function *PerfMonitor::getAtExit() {
2424

2525
if (!F) {
2626
GlobalValue::LinkageTypes Linkage = Function::ExternalLinkage;
27-
FunctionType *Ty = FunctionType::get(Builder.getInt32Ty(),
28-
{Builder.getInt8PtrTy()}, false);
27+
FunctionType *Ty =
28+
FunctionType::get(Builder.getInt32Ty(), {Builder.getPtrTy()}, false);
2929
F = Function::Create(Ty, Linkage, Name, M);
3030
}
3131

@@ -44,12 +44,12 @@ void PerfMonitor::addToGlobalConstructors(Function *Fn) {
4444
GV->eraseFromParent();
4545
}
4646

47-
StructType *ST = StructType::get(Builder.getInt32Ty(), Fn->getType(),
48-
Builder.getInt8PtrTy());
47+
StructType *ST =
48+
StructType::get(Builder.getInt32Ty(), Fn->getType(), Builder.getPtrTy());
4949

5050
V.push_back(
5151
ConstantStruct::get(ST, Builder.getInt32(10), Fn,
52-
ConstantPointerNull::get(Builder.getInt8PtrTy())));
52+
ConstantPointerNull::get(Builder.getPtrTy())));
5353
ArrayType *Ty = ArrayType::get(ST, V.size());
5454

5555
GV = new GlobalVariable(*M, Ty, true, GlobalValue::AppendingLinkage,
@@ -246,7 +246,7 @@ Function *PerfMonitor::insertInitFunction(Function *FinalReporting) {
246246

247247
// Register the final reporting function with atexit().
248248
Value *FinalReportingPtr =
249-
Builder.CreatePointerCast(FinalReporting, Builder.getInt8PtrTy());
249+
Builder.CreatePointerCast(FinalReporting, Builder.getPtrTy());
250250
Function *AtExitFn = getAtExit();
251251
Builder.CreateCall(AtExitFn, {FinalReportingPtr});
252252

polly/lib/CodeGen/RuntimeDebugBuilder.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,7 @@ Function *RuntimeDebugBuilder::getVPrintF(PollyIRBuilder &Builder) {
3434
if (!F) {
3535
GlobalValue::LinkageTypes Linkage = Function::ExternalLinkage;
3636
FunctionType *Ty = FunctionType::get(
37-
Builder.getInt32Ty(), {Builder.getInt8PtrTy(), Builder.getInt8PtrTy()},
38-
false);
37+
Builder.getInt32Ty(), {Builder.getPtrTy(), Builder.getPtrTy()}, false);
3938
F = Function::Create(Ty, Linkage, Name, M);
4039
}
4140

@@ -78,7 +77,7 @@ prepareValuesForPrinting(PollyIRBuilder &Builder, ArrayRef<Value *> Values) {
7877
assert(Ty->getIntegerBitWidth() &&
7978
"Integer types larger 64 bit not supported");
8079
} else if (isa<PointerType>(Ty)) {
81-
if (Ty == Builder.getInt8PtrTy(4)) {
80+
if (Ty == Builder.getPtrTy(4)) {
8281
Val = Builder.CreateGEP(Builder.getInt8Ty(), Val, Builder.getInt64(0));
8382
} else {
8483
Val = Builder.CreatePtrToInt(Val, Builder.getInt64Ty());
@@ -148,7 +147,7 @@ void RuntimeDebugBuilder::createFlush(PollyIRBuilder &Builder) {
148147
if (!F) {
149148
GlobalValue::LinkageTypes Linkage = Function::ExternalLinkage;
150149
FunctionType *Ty =
151-
FunctionType::get(Builder.getInt32Ty(), Builder.getInt8PtrTy(), false);
150+
FunctionType::get(Builder.getInt32Ty(), Builder.getPtrTy(), false);
152151
F = Function::Create(Ty, Linkage, Name, M);
153152
}
154153

0 commit comments

Comments
 (0)