Skip to content

Commit a4380fe

Browse files
authored
[lldb/cmake] Remove special handling of OBJECT libraries (#141066)
Nothing in lldb sets this. And even if they did, llvm_add_library should know how to handle that.
1 parent 34deb76 commit a4380fe

File tree

1 file changed

+16
-20
lines changed

1 file changed

+16
-20
lines changed

lldb/cmake/modules/AddLLDB.cmake

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -93,29 +93,25 @@ function(add_lldb_library name)
9393
set(libkind STATIC)
9494
endif()
9595

96-
if (PARAM_OBJECT)
97-
add_library(${name} ${libkind} ${srcs})
98-
else()
99-
if(PARAM_ENTITLEMENTS)
100-
set(pass_ENTITLEMENTS ENTITLEMENTS ${PARAM_ENTITLEMENTS})
101-
endif()
96+
if(PARAM_ENTITLEMENTS)
97+
set(pass_ENTITLEMENTS ENTITLEMENTS ${PARAM_ENTITLEMENTS})
98+
endif()
10299

103-
if(LLDB_NO_INSTALL_DEFAULT_RPATH)
104-
set(pass_NO_INSTALL_RPATH NO_INSTALL_RPATH)
105-
endif()
100+
if(LLDB_NO_INSTALL_DEFAULT_RPATH)
101+
set(pass_NO_INSTALL_RPATH NO_INSTALL_RPATH)
102+
endif()
106103

107-
llvm_add_library(${name} ${libkind} ${srcs}
108-
LINK_LIBS ${PARAM_LINK_LIBS}
109-
DEPENDS ${PARAM_DEPENDS}
110-
${pass_ENTITLEMENTS}
111-
${pass_NO_INSTALL_RPATH}
112-
)
104+
llvm_add_library(${name} ${libkind} ${srcs}
105+
LINK_LIBS ${PARAM_LINK_LIBS}
106+
DEPENDS ${PARAM_DEPENDS}
107+
${pass_ENTITLEMENTS}
108+
${pass_NO_INSTALL_RPATH}
109+
)
113110

114-
if(CLANG_LINK_CLANG_DYLIB)
115-
target_link_libraries(${name} PRIVATE clang-cpp)
116-
else()
117-
target_link_libraries(${name} PRIVATE ${PARAM_CLANG_LIBS})
118-
endif()
111+
if(CLANG_LINK_CLANG_DYLIB)
112+
target_link_libraries(${name} PRIVATE clang-cpp)
113+
else()
114+
target_link_libraries(${name} PRIVATE ${PARAM_CLANG_LIBS})
119115
endif()
120116

121117
# A target cannot be changed to a FRAMEWORK after calling install() because

0 commit comments

Comments
 (0)