Skip to content

Commit a4459fe

Browse files
committed
[lldb] Fix use of undefined type 'lldb_private::UtilityFunction'
We were returning the default constructed unique_pointer from TypeSystem.h for which the compiler does not have a definition. Move the implementation into the cpp file.
1 parent 05bef88 commit a4459fe

File tree

2 files changed

+9
-14
lines changed

2 files changed

+9
-14
lines changed

lldb/include/lldb/Symbol/TypeSystem.h

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -466,9 +466,7 @@ class TypeSystem : public PluginInterface {
466466
}
467467

468468
virtual std::unique_ptr<UtilityFunction>
469-
CreateUtilityFunction(std::string text, std::string name) {
470-
return {};
471-
}
469+
CreateUtilityFunction(std::string text, std::string name);
472470

473471
virtual PersistentExpressionState *GetPersistentExpressionState() {
474472
return nullptr;

lldb/source/Symbol/TypeSystem.cpp

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,22 +6,14 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
//
10-
// TypeSystem.cpp
11-
// lldb
12-
//
13-
// Created by Ryan Brown on 3/29/15.
14-
//
15-
//
16-
179
#include "lldb/Symbol/TypeSystem.h"
18-
19-
#include <set>
20-
2110
#include "lldb/Core/PluginManager.h"
11+
#include "lldb/Expression/UtilityFunction.h"
2212
#include "lldb/Symbol/CompilerType.h"
2313
#include "lldb/Target/Language.h"
2414

15+
#include <set>
16+
2517
using namespace lldb_private;
2618
using namespace lldb;
2719

@@ -179,6 +171,11 @@ TypeSystem::DeclContextFindDeclByName(void *opaque_decl_ctx, ConstString name,
179171
return std::vector<CompilerDecl>();
180172
}
181173

174+
std::unique_ptr<UtilityFunction>
175+
TypeSystem::CreateUtilityFunction(std::string text, std::string name) {
176+
return {};
177+
}
178+
182179
#pragma mark TypeSystemMap
183180

184181
TypeSystemMap::TypeSystemMap()

0 commit comments

Comments
 (0)