clean up

Author: dschuff

lld/wasm/InputFiles.cpp

@@ -335,7 +335,7 @@ void ObjFile::addLegacyIndirectFunctionTableIfNeeded(
   const WasmGlobalType *globalType = nullptr;
   const WasmSignature *signature = nullptr;
   auto *wasmSym =
-      make<WasmSymbol>(std::move(info), globalType, &tableImport->Table, signature);
+      make<WasmSymbol>(info, globalType, &tableImport->Table, signature);
   Symbol *sym = createUndefined(*wasmSym, false);
   // We're only sure it's a TableSymbol if the createUndefined succeeded.
   if (errorCount())

llvm/include/llvm/Object/Wasm.h

@@ -34,7 +34,7 @@ namespace object {
 
 class WasmSymbol {
 public:
-  WasmSymbol(const wasm::WasmSymbolInfo &&Info,
+  WasmSymbol(const wasm::WasmSymbolInfo &Info,
              const wasm::WasmGlobalType *GlobalType,
              const wasm::WasmTableType *TableType,
              const wasm::WasmSignature *Signature)
@@ -45,7 +45,7 @@ class WasmSymbol {
 
   // Symbol info as represented in the symbol's 'syminfo' entry of an object
   // file's symbol table.
-  const wasm::WasmSymbolInfo Info;
+  wasm::WasmSymbolInfo Info;
   const wasm::WasmGlobalType *GlobalType;
   const wasm::WasmTableType *TableType;
   const wasm::WasmSignature *Signature;

llvm/lib/Object/WasmObjectFile.cpp

@@ -842,7 +842,7 @@ Error WasmObjectFile::parseLinkingSectionSymtab(ReadContext &Ctx) {
       return make_error<GenericBinaryError>("duplicate symbol name " +
                                                 Twine(Info.Name),
                                             object_error::parse_failed);
-    Symbols.emplace_back(std::move(Info), GlobalType, TableType,
+    Symbols.emplace_back(Info, GlobalType, TableType,
                          Signature);
     LLVM_DEBUG(dbgs() << "Adding symbol: " << Symbols.back() << "\n");
   }
@@ -1451,7 +1451,7 @@ Error WasmObjectFile::parseExportSection(ReadContext &Ctx) {
     }
     Exports.push_back(Ex);
     if (Ex.Kind != wasm::WASM_EXTERNAL_MEMORY) {
-      Symbols.emplace_back(std::move(Info), GlobalType,
+      Symbols.emplace_back(Info, GlobalType,
                            TableType, Signature);
       LLVM_DEBUG(dbgs() << "Adding symbol: " << Symbols.back() << "\n");
     }

llvm/tools/obj2yaml/wasm2yaml.cpp

@@ -124,7 +124,7 @@ WasmDumper::dumpCustomSection(const WasmSection &WasmSec) {
     }
 
     uint32_t SymbolIndex = 0;
-    for (const auto &Sym : Obj.symbols()) {
+    for (const object::SymbolRef &Sym : Obj.symbols()) {
       const wasm::WasmSymbolInfo& Symbol = Obj.getWasmSymbol(Sym).Info;
       WasmYAML::SymbolInfo Info;
       Info.Index = SymbolIndex++;