Skip to content

Commit a5403a3

Browse files
authored
[libcxx] Amend XFAIL for failing tests on Windows (#70422)
Some tests starting passing/failing after #69431 because Clang no longer enables -fdelayed-template-parsing by default on Windows with C++20.
1 parent e6971e5 commit a5403a3

File tree

4 files changed

+16
-3
lines changed

4 files changed

+16
-3
lines changed

libcxx/test/libcxx/atomics/diagnose_invalid_memory_order.verify.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// This test fails because diagnose_if doesn't emit all of the diagnostics
10-
// when -fdelayed-template-parsing is enabled, like it is in MSVC mode.
11-
// XFAIL: msvc
9+
// This test fails with Clang <18 because diagnose_if doesn't emit all of the
10+
// diagnostics when -fdelayed-template-parsing is enabled, like it is in MSVC
11+
// mode.
12+
// XFAIL: msvc && (clang-16 || clang-17)
1213

1314
// REQUIRES: diagnose-if-support
1415

libcxx/test/libcxx/fuzzing/random.pass.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
// This test fails because Clang no longer enables -fdelayed-template-parsing
10+
// by default on Windows with C++20 (#69431).
11+
// XFAIL: msvc && clang-18
12+
913
// UNSUPPORTED: c++03, c++11
1014

1115
#include <cassert>

libcxx/test/std/depr/depr.c.headers/math_h.pass.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
// This test fails because Clang no longer enables -fdelayed-template-parsing
10+
// by default on Windows with C++20 (#69431).
11+
// XFAIL: msvc && clang-18
12+
913
// <math.h>
1014

1115
#include <math.h>

libcxx/test/std/numerics/c.math/cmath.pass.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,10 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9+
// This test fails because Clang no longer enables -fdelayed-template-parsing
10+
// by default on Windows with C++20 (#69431).
11+
// XFAIL: msvc && clang-18
12+
913
// <cmath>
1014

1115
#include <cmath>

0 commit comments

Comments
 (0)