Skip to content

Commit a67b85e

Browse files
authored
Add llvm-dlltool to the toolchain list (#72563)
This adds dlltool to the list of tools which don't get excluded from installation when LLVM_INSTALL_TOOLCHAIN_ONLY is set. The most important effect here is that this tool will now be included in the official Windows release. While llvm-lib reuses the dlltool machinary internally and has many of the same capabilities, it does not expose the functionality controller by the '-k' flag, which is currently the only way to create import libraries for i386 with stdcall symbols from a module definition alone. We avoid changing llvm-lib tool, since it is designed to emulate LIB.EXE from MSVC toolchain, and as this functionality is not supported there, we would have had to introduce an LLVM extension flag in order to support it. See https://reviews.llvm.org/D36548 for reference on rationale for dlltool '-k' flag.
1 parent 7aaa86b commit a67b85e

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

llvm/cmake/modules/AddLLVM.cmake

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1307,6 +1307,7 @@ if(NOT LLVM_TOOLCHAIN_TOOLS)
13071307
llvm-ar
13081308
llvm-cov
13091309
llvm-cxxfilt
1310+
llvm-dlltool
13101311
llvm-dwp
13111312
llvm-ranlib
13121313
llvm-lib

0 commit comments

Comments
 (0)