feedback review

Keenuts · Keenuts · commit a733a2ca6164 · 2024-05-07T10:52:53.000+02:00
diff --git a/clang/lib/CodeGen/CGCall.cpp b/clang/lib/CodeGen/CGCall.cpp
@@ -4832,7 +4832,7 @@ llvm::CallInst *CodeGenFunction::EmitRuntimeCall(llvm::FunctionCallee callee,
   call->setCallingConv(getRuntimeCC());
 
   if (getTarget().getTriple().isSPIRVLogical() && call->isConvergent())
-    return dyn_cast<llvm::CallInst>(addControlledConvergenceToken(call));
+    return addControlledConvergenceToken(call);
   return call;
 }
 
diff --git a/clang/lib/CodeGen/CodeGenFunction.h b/clang/lib/CodeGen/CodeGenFunction.h
@@ -5081,7 +5081,7 @@ class CodeGenFunction : public CodeGenTypeCache {
   // convergence instructions.
   template <typename CallType>
   CallType *addControlledConvergenceToken(CallType *Input) {
-    return dyn_cast<CallType>(
+    return cast<CallType>(
         addConvergenceControlToken(Input, ConvergenceTokenStack.back()));
   }
 

Original file line number	Diff line number	Diff line change
`@@ -4832,7 +4832,7 @@ llvm::CallInst *CodeGenFunction::EmitRuntimeCall(llvm::FunctionCallee callee,`
`4832`	`4832`	`call->setCallingConv(getRuntimeCC());`
`4833`	`4833`
`4834`	`4834`	`if (getTarget().getTriple().isSPIRVLogical() && call->isConvergent())`
`4835`		`- return dyn_cast<llvm::CallInst>(addControlledConvergenceToken(call));`
	`4835`	`+ return addControlledConvergenceToken(call);`
`4836`	`4836`	`return call;`
`4837`	`4837`	`}`
`4838`	`4838`
Original file line number	Diff line number	Diff line change
`@@ -5081,7 +5081,7 @@ class CodeGenFunction : public CodeGenTypeCache {`
`5081`	`5081`	`// convergence instructions.`
`5082`	`5082`	`template <typename CallType>`
`5083`	`5083`	`CallType addControlledConvergenceToken(CallType Input) {`
`5084`		`- return dyn_cast<CallType>(`
	`5084`	`+ return cast<CallType>(`
`5085`	`5085`	`addConvergenceControlToken(Input, ConvergenceTokenStack.back()));`
`5086`	`5086`	`}`
`5087`	`5087`