Skip to content

Commit a74fb7c

Browse files
committed
Updates per review.
1 parent b35bf4e commit a74fb7c

File tree

2 files changed

+15
-7
lines changed

2 files changed

+15
-7
lines changed

llvm/docs/LangRef.rst

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1189,9 +1189,12 @@ Currently, only the following parameter attributes are defined:
11891189
value should be sign-extended to the extent required by the target's
11901190
ABI (which is usually 32-bits) by the caller (for a parameter) or
11911191
the callee (for a return value).
1192-
``noext`` This indicates to the code generator that the parameter or return
1192+
``noext``
1193+
This indicates to the code generator that the parameter or return
11931194
value has the high bits undefined, as for a struct in register, and
1194-
therefore does not need to be sign or zero extended.
1195+
therefore does not need to be sign or zero extended. This is the same
1196+
as default behavior and is only actually used (by some targets) to
1197+
validate that one of the attributes is always present.
11951198
``inreg``
11961199
This indicates that this parameter or return value should be treated
11971200
in a special target-dependent fashion while emitting code for

llvm/lib/Target/SystemZ/SystemZISelLowering.cpp

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -9820,8 +9820,7 @@ SDValue SystemZTargetLowering::lowerVECREDUCE_ADD(SDValue Op,
98209820

98219821
// Only consider a function fully internal as long as it has local linkage
98229822
// and is not used in any other way than acting as the called function at
9823-
// call sites. TODO: Remove this when/if all internal functions adhere to
9824-
// the ABI.
9823+
// call sites.
98259824
bool SystemZTargetLowering::isFullyInternal(const Function *Fn) const {
98269825
if (!Fn->hasLocalLinkage())
98279826
return false;
@@ -9842,9 +9841,15 @@ verifyNarrowIntegerArgs(const SmallVectorImpl<ISD::OutputArg> &Outs,
98429841
if (IsInternal || !Subtarget.isTargetELF())
98439842
return;
98449843

9845-
// Temporarily only do the check when explicitly requested.
9846-
if (/* !getTargetMachine().Options.VerifyArgABICompliance && */
9847-
!EnableIntArgExtCheck)
9844+
// Temporarily only do the check when explicitly requested, until it can be
9845+
// enabled by default.
9846+
if (!EnableIntArgExtCheck)
9847+
return;
9848+
9849+
if (EnableIntArgExtCheck.getNumOccurrences()) {
9850+
if (!EnableIntArgExtCheck)
9851+
return;
9852+
} else if (!getTargetMachine().Options.VerifyArgABICompliance)
98489853
return;
98499854

98509855
for (unsigned i = 0; i < Outs.size(); ++i) {

0 commit comments

Comments
 (0)