Skip to content

Commit a79e257

Browse files
authored
[HLSL] XFAIL smoothstep.ll and SV_GroupIndex.ll SPIR-V backend tests (#136343)
When SPIRV-Tools is enabled, tests that specify the target environment `vulkan1.3` in the validation step fail. This is because SPIRV-Tools seems to have [grown some capability checks for vulkan 1.3](KhronosGroup/SPIRV-Tools@7e41c71). The failing tests are: - `CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll` - `CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll` For now, the fix is to XFAIL these tests to unblock the pipeline. Issue #136344 tracks the long-term solution for this.
1 parent 5dcfa61 commit a79e257

File tree

2 files changed

+6
-0
lines changed

2 files changed

+6
-0
lines changed

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s
22
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
33

4+
; TODO(#136344): This test currently fails when --target-env vulkan1.3 is specified.
5+
; XFAIL: spirv-tools
6+
47
; CHECK-DAG: %[[#int:]] = OpTypeInt 32 0
58
; CHECK-DAG: %[[#ptr_Input_int:]] = OpTypePointer Input %[[#int]]
69
; CHECK-DAG: %[[#LocalInvocationIndex:]] = OpVariable %[[#ptr_Input_int]] Input

llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
22
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
33

4+
; TODO(#136344): This test currently fails when --target-env vulkan1.3 is specified.
5+
; XFAIL: spirv-tools
6+
47
; Make sure SPIRV operation function calls for smoothstep are lowered correctly.
58

69
; CHECK-DAG: %[[#op_ext_glsl:]] = OpExtInstImport "GLSL.std.450"

0 commit comments

Comments
 (0)