handle range attribute in computeConstantRange

Author: andjo403

llvm/lib/Analysis/ValueTracking.cpp

@@ -9126,12 +9126,19 @@ ConstantRange llvm::computeConstantRange(const Value *V, bool ForSigned,
     // TODO: Return ConstantRange.
     setLimitForFPToI(cast<Instruction>(V), Lower, Upper);
     CR = ConstantRange::getNonEmpty(Lower, Upper);
-  }
+  } else if (const Argument *A = dyn_cast<Argument>(V))
+    if (std::optional<ConstantRange> Range = A->getRange())
+      CR = *Range;
 
-  if (auto *I = dyn_cast<Instruction>(V))
+  if (auto *I = dyn_cast<Instruction>(V)) {
     if (auto *Range = IIQ.getMetadata(I, LLVMContext::MD_range))
       CR = CR.intersectWith(getConstantRangeFromMetadata(*Range));
 
+    if (const CallBase *CB = dyn_cast<CallBase>(V))
+      if (std::optional<ConstantRange> Range = CB->getRange())
+        CR = CR.intersectWith(*Range);
+  }
+
   if (CtxI && AC) {
     // Try to restrict the range based on information from assumptions.
     for (auto &AssumeVH : AC->assumptionsFor(V)) {

llvm/test/Transforms/InstSimplify/icmp-constant.ll

@@ -1271,8 +1271,7 @@ define <2 x i1> @neg_icmp_eq_non_zero_range_call_vec() {
 
 define i1 @icmp_eq_constant_range_attr(i8 range(i8 0, 10) %i) {
 ; CHECK-LABEL: @icmp_eq_constant_range_attr(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i8 [[I:%.*]], 10
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 false
 ;
   %cmp = icmp eq i8 %i, 10
   ret i1 %cmp
@@ -1304,8 +1303,7 @@ define i1 @icmp_eq_constant_range_return() {
 define i1 @neg_icmp_eq_constant_range_return() {
 ; CHECK-LABEL: @neg_icmp_eq_constant_range_return(
 ; CHECK-NEXT:    [[I:%.*]] = call i8 @returns_contain_ten_range_helper()
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i8 [[I]], 10
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 false
 ;
   %i = call i8 @returns_contain_ten_range_helper()
   %cmp = icmp eq i8 %i, 10
@@ -1315,8 +1313,7 @@ define i1 @neg_icmp_eq_constant_range_return() {
 define i1 @icmp_eq_constant_range_call() {
 ; CHECK-LABEL: @icmp_eq_constant_range_call(
 ; CHECK-NEXT:    [[I:%.*]] = call range(i8 0, 10) i8 @returns_i8_helper()
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq i8 [[I]], 10
-; CHECK-NEXT:    ret i1 [[CMP]]
+; CHECK-NEXT:    ret i1 false
 ;
   %i = call range(i8 0, 10) i8 @returns_i8_helper()
   %cmp = icmp eq i8 %i, 10
@@ -1336,8 +1333,7 @@ define i1 @neg_icmp_eq_constant_range_call() {
 
 define <2 x i1> @icmp_eq_constant_range_attr_vec(<2 x i8> range(i8 0, 10) %i) {
 ; CHECK-LABEL: @icmp_eq_constant_range_attr_vec(
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq <2 x i8> [[I:%.*]], <i8 10, i8 10>
-; CHECK-NEXT:    ret <2 x i1> [[CMP]]
+; CHECK-NEXT:    ret <2 x i1> zeroinitializer
 ;
   %cmp = icmp eq <2 x i8> %i, <i8 10, i8 10>
   ret <2 x i1> %cmp
@@ -1358,8 +1354,7 @@ declare range(i8 0, 11) <2 x i8> @returns_contain_ten_range_helper_vec()
 define <2 x i1> @icmp_eq_constant_range_return_vec() {
 ; CHECK-LABEL: @icmp_eq_constant_range_return_vec(
 ; CHECK-NEXT:    [[I:%.*]] = call <2 x i8> @returns_non_ten_range_helper_vec()
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq <2 x i8> [[I]], <i8 10, i8 10>
-; CHECK-NEXT:    ret <2 x i1> [[CMP]]
+; CHECK-NEXT:    ret <2 x i1> zeroinitializer
 ;
   %i = call <2 x i8> @returns_non_ten_range_helper_vec()
   %cmp = icmp eq <2 x i8> %i, <i8 10, i8 10>
@@ -1380,8 +1375,7 @@ define <2 x i1> @neg_icmp_eq_constant_range_return_vec() {
 define <2 x i1> @icmp_eq_constant_range_call_vec() {
 ; CHECK-LABEL: @icmp_eq_constant_range_call_vec(
 ; CHECK-NEXT:    [[I:%.*]] = call range(i8 0, 10) <2 x i8> @returns_i8_helper_vec()
-; CHECK-NEXT:    [[CMP:%.*]] = icmp eq <2 x i8> [[I]], <i8 10, i8 10>
-; CHECK-NEXT:    ret <2 x i1> [[CMP]]
+; CHECK-NEXT:    ret <2 x i1> zeroinitializer
 ;
   %i = call range(i8 0, 10) <2 x i8> @returns_i8_helper_vec()
   %cmp = icmp eq <2 x i8> %i, <i8 10, i8 10>