Changing order of legalization passes has more determinisc crash behavior. introduced in #9c29217 needs to be one of the last steps of legalization

farzonl · farzonl · commit a9e58743556b · 2025-01-16T23:23:35.000-05:00
diff --git a/llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp b/llvm/lib/Target/SPIRV/SPIRVTargetMachine.cpp
@@ -218,8 +218,8 @@ bool SPIRVPassConfig::addIRTranslator() {
 }
 
 void SPIRVPassConfig::addPreLegalizeMachineIR() {
-  addPass(createSPIRVPreLegalizerPass());
   addPass(createSPIRVPreLegalizerCombiner());
+  addPass(createSPIRVPreLegalizerPass());
 }
 
 // Use the default legalizer.

Original file line number	Diff line number	Diff line change
`@@ -218,8 +218,8 @@ bool SPIRVPassConfig::addIRTranslator() {`
`218`	`218`	`}`
`219`	`219`
`220`	`220`	`void SPIRVPassConfig::addPreLegalizeMachineIR() {`
`221`		`- addPass(createSPIRVPreLegalizerPass());`
`222`	`221`	`addPass(createSPIRVPreLegalizerCombiner());`
	`222`	`+ addPass(createSPIRVPreLegalizerPass());`
`223`	`223`	`}`
`224`	`224`
`225`	`225`	`// Use the default legalizer.`