Skip to content

Commit aa03327

Browse files
authored
[X86][AVX] Add missing X86ISD::VBROADCAST(v2i64 -> v4i64) isel pattern for AVX1 targets (#102853)
An internal bug revealed that this form can be formed from existing combines, and then fail to select. Use the same pattern as v2f64 -> v4f64 (the instructions are moving bits around the actual type does not matter here).
1 parent 2c62d08 commit aa03327

File tree

2 files changed

+28
-0
lines changed

2 files changed

+28
-0
lines changed

llvm/lib/Target/X86/X86InstrSSE.td

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7797,6 +7797,11 @@ let Predicates = [HasAVX1Only] in {
77977797
(VPSHUFDri (VMOV64toPQIrr GR64:$src), 0x44)>;
77987798
def : Pat<(v2i64 (X86VBroadcastld64 addr:$src)),
77997799
(VMOVDDUPrm addr:$src)>;
7800+
7801+
def : Pat<(v4i64 (X86VBroadcast v2i64:$src)),
7802+
(VINSERTF128rr (INSERT_SUBREG (v4i64 (IMPLICIT_DEF)),
7803+
(v2i64 (VPSHUFDri VR128:$src, 0x44)), sub_xmm),
7804+
(v2i64 (VPSHUFDri VR128:$src, 0x44)), 1)>;
78007805
}
78017806

78027807
//===----------------------------------------------------------------------===//

llvm/test/CodeGen/X86/combine-concatvectors.ll

Lines changed: 23 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -118,3 +118,26 @@ define <4 x float> @concat_of_broadcast_v4f32_v8f32(ptr %a0, ptr %a1, ptr %a2) {
118118
%shuffle1 = shufflevector <8 x float> %ld2, <8 x float> %shuffle, <4 x i32> <i32 6, i32 15, i32 12, i32 3>
119119
ret <4 x float> %shuffle1
120120
}
121+
122+
define <4 x i64> @broadcast_of_shuffle_v2i64_v4i64(<16 x i8> %vecinit.i) {
123+
; AVX1-LABEL: broadcast_of_shuffle_v2i64_v4i64:
124+
; AVX1: # %bb.0: # %entry
125+
; AVX1-NEXT: vpsllq $56, %xmm0, %xmm0
126+
; AVX1-NEXT: vpshufd {{.*#+}} xmm0 = xmm0[0,1,0,1]
127+
; AVX1-NEXT: vinsertf128 $1, %xmm0, %ymm0, %ymm0
128+
; AVX1-NEXT: retq
129+
;
130+
; AVX2-LABEL: broadcast_of_shuffle_v2i64_v4i64:
131+
; AVX2: # %bb.0: # %entry
132+
; AVX2-NEXT: vpsllq $56, %xmm0, %xmm0
133+
; AVX2-NEXT: vpbroadcastq %xmm0, %ymm0
134+
; AVX2-NEXT: retq
135+
entry:
136+
%vecinit15.i = shufflevector <16 x i8> %vecinit.i, <16 x i8> poison, <16 x i32> zeroinitializer
137+
%0 = bitcast <16 x i8> %vecinit15.i to <2 x i64>
138+
%1 = extractelement <2 x i64> %0, i64 0
139+
%2 = and i64 %1, -72057594037927936 ; 0xFF00 0000 0000 0000
140+
%3 = insertelement <4 x i64> poison, i64 %2, i64 0
141+
%4 = shufflevector <4 x i64> %3, <4 x i64> poison, <4 x i32> zeroinitializer
142+
ret <4 x i64> %4
143+
}

0 commit comments

Comments
 (0)