Skip to content

Commit aa6d0a2

Browse files
committed
Refactor test to read the top and bottom stack frame's respective pointers instead of trying to take the entire range
1 parent 2d192f6 commit aa6d0a2

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

lldb/test/API/functionalities/process_save_core_minidump/TestProcessSaveCoreMinidump.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,10 @@
99
from lldbsuite.test.lldbtest import *
1010
from lldbsuite.test import lldbutil
1111

12-
1312
class ProcessSaveCoreMinidumpTestCase(TestBase):
1413
def verify_core_file(
1514
self, core_path, expected_pid, expected_modules, expected_threads
1615
):
17-
breakpoint()
1816
# To verify, we'll launch with the mini dump
1917
target = self.dbg.CreateTarget(None)
2018
process = target.LoadCore(core_path)
@@ -44,13 +42,14 @@ def verify_core_file(
4442
thread_id = thread.GetThreadID()
4543
self.assertIn(thread_id, expected_threads)
4644
oldest_frame = thread.GetFrameAtIndex(thread.GetNumFrames() - 1)
47-
stack_start = oldest_frame.GetSymbol().GetStartAddress().GetFileAddress()
45+
stack_start = oldest_frame.GetSP()
4846
frame = thread.GetFrameAtIndex(0)
4947
sp = frame.GetSP()
50-
stack_size = stack_start - (sp - red_zone)
51-
byte_array = process.ReadMemory(sp - red_zone + 1, stack_size, error)
52-
self.assertTrue(error.Success(), "Failed to read stack")
53-
self.assertEqual(stack_size - 1, len(byte_array), "Incorrect stack size read"),
48+
error = lldb.SBError()
49+
process.ReadMemory(sp - red_zone + 1, 1, error)
50+
self.assertTrue(error.Success(), error.GetCString())
51+
process.ReadMemory(stack_start - 1, 1, error)
52+
self.assertTrue(error.Success(), error.GetCString())
5453

5554

5655
self.dbg.DeleteTarget(target)
@@ -59,6 +58,7 @@ def verify_core_file(
5958
@skipUnlessPlatform(["linux"])
6059
def test_save_linux_mini_dump(self):
6160
"""Test that we can save a Linux mini dump."""
61+
6262
self.build()
6363
exe = self.getBuildArtifact("a.out")
6464
core_stack = self.getBuildArtifact("core.stack.dmp")

0 commit comments

Comments
 (0)