Skip to content

Commit aae2592

Browse files
artagnonartagnon
authored
LoopVersioning: improve a test, regen with UTC (#122876)
Improve a test by replacing undef with poison, and regenerate it using UpdateTestChecks.
1 parent e409204 commit aae2592

File tree

1 file changed

+100
-21
lines changed

1 file changed

+100
-21
lines changed

‎llvm/test/Transforms/LoopVersioning/incorrect-phi.ll

Lines changed: 100 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -1,62 +1,141 @@
1+
; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
12
; RUN: opt -passes=loop-versioning -S < %s | FileCheck %s
23

34
; Make sure all PHIs are properly updated in the exit block. Based on
45
; PR28037.
56

6-
target datalayout = "e-m:o-i64:64-f80:128-n8:16:32:64-S128"
7-
target triple = "x86_64-unknown-linux-gnu"
8-
97
@x = external global [2 x [3 x [5 x i16]]]
108

11-
; CHECK-LABEL: @phi_with_undef
12-
define void @phi_with_undef() {
9+
define void @phi_with_poison() {
10+
; CHECK-LABEL: define void @phi_with_poison() {
11+
; CHECK-NEXT: [[BB6_LVER_CHECK:.*:]]
12+
; CHECK-NEXT: [[MUL:%.*]] = call { i64, i1 } @llvm.umul.with.overflow.i64(i64 10, i64 0)
13+
; CHECK-NEXT: [[MUL_RESULT:%.*]] = extractvalue { i64, i1 } [[MUL]], 0
14+
; CHECK-NEXT: [[MUL_OVERFLOW:%.*]] = extractvalue { i64, i1 } [[MUL]], 1
15+
; CHECK-NEXT: [[TMP0:%.*]] = sub i64 0, [[MUL_RESULT]]
16+
; CHECK-NEXT: br i1 poison, label %[[BB6_PH_LVER_ORIG:.*]], label %[[BB6_PH:.*]]
17+
; CHECK: [[BB6_PH_LVER_ORIG]]:
18+
; CHECK-NEXT: br label %[[BB6_LVER_ORIG:.*]]
19+
; CHECK: [[BB6_LVER_ORIG]]:
20+
; CHECK-NEXT: [[_TMP1423_LVER_ORIG:%.*]] = phi i64 [ poison, %[[BB6_PH_LVER_ORIG]] ], [ [[_TMP142_LVER_ORIG:%.*]], %[[BB6_LVER_ORIG]] ]
21+
; CHECK-NEXT: [[_TMP123_LVER_ORIG:%.*]] = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 poison
22+
; CHECK-NEXT: [[_TMP126_LVER_ORIG:%.*]] = getelementptr [3 x [5 x i16]], ptr [[_TMP123_LVER_ORIG]], i16 0, i64 [[_TMP1423_LVER_ORIG]]
23+
; CHECK-NEXT: [[_TMP129_LVER_ORIG:%.*]] = getelementptr [5 x i16], ptr [[_TMP126_LVER_ORIG]], i16 0, i64 poison
24+
; CHECK-NEXT: [[_TMP130_LVER_ORIG:%.*]] = load i16, ptr [[_TMP129_LVER_ORIG]], align 2
25+
; CHECK-NEXT: store i16 poison, ptr @x, align 2
26+
; CHECK-NEXT: [[_TMP142_LVER_ORIG]] = add i64 [[_TMP1423_LVER_ORIG]], 1
27+
; CHECK-NEXT: br i1 false, label %[[BB6_LVER_ORIG]], label %[[LOOP_EXIT_LOOPEXIT:.*]]
28+
; CHECK: [[BB6_PH]]:
29+
; CHECK-NEXT: br label %[[BB6:.*]]
30+
; CHECK: [[BB6]]:
31+
; CHECK-NEXT: [[_TMP1423:%.*]] = phi i64 [ poison, %[[BB6_PH]] ], [ [[_TMP142:%.*]], %[[BB6]] ]
32+
; CHECK-NEXT: [[_TMP123:%.*]] = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 poison
33+
; CHECK-NEXT: [[_TMP126:%.*]] = getelementptr [3 x [5 x i16]], ptr [[_TMP123]], i16 0, i64 [[_TMP1423]]
34+
; CHECK-NEXT: [[_TMP129:%.*]] = getelementptr [5 x i16], ptr [[_TMP126]], i16 0, i64 poison
35+
; CHECK-NEXT: [[_TMP130:%.*]] = load i16, ptr [[_TMP129]], align 2
36+
; CHECK-NEXT: store i16 poison, ptr @x, align 2
37+
; CHECK-NEXT: [[_TMP142]] = add i64 [[_TMP1423]], 1
38+
; CHECK-NEXT: br i1 false, label %[[BB6]], label %[[LOOP_EXIT_LOOPEXIT1:.*]]
39+
; CHECK: [[LOOP_EXIT_LOOPEXIT]]:
40+
; CHECK-NEXT: [[_TMP142_LCSSA_PH:%.*]] = phi i64 [ [[_TMP142_LVER_ORIG]], %[[BB6_LVER_ORIG]] ]
41+
; CHECK-NEXT: [[SPLIT_PH:%.*]] = phi i16 [ poison, %[[BB6_LVER_ORIG]] ]
42+
; CHECK-NEXT: br label %[[LOOP_EXIT:.*]]
43+
; CHECK: [[LOOP_EXIT_LOOPEXIT1]]:
44+
; CHECK-NEXT: [[_TMP142_LCSSA_PH2:%.*]] = phi i64 [ [[_TMP142]], %[[BB6]] ]
45+
; CHECK-NEXT: [[SPLIT_PH3:%.*]] = phi i16 [ poison, %[[BB6]] ]
46+
; CHECK-NEXT: br label %[[LOOP_EXIT]]
47+
; CHECK: [[LOOP_EXIT]]:
48+
; CHECK-NEXT: [[_TMP142_LCSSA:%.*]] = phi i64 [ [[_TMP142_LCSSA_PH]], %[[LOOP_EXIT_LOOPEXIT]] ], [ [[_TMP142_LCSSA_PH2]], %[[LOOP_EXIT_LOOPEXIT1]] ]
49+
; CHECK-NEXT: [[SPLIT:%.*]] = phi i16 [ [[SPLIT_PH]], %[[LOOP_EXIT_LOOPEXIT]] ], [ [[SPLIT_PH3]], %[[LOOP_EXIT_LOOPEXIT1]] ]
50+
; CHECK-NEXT: br label %[[BB9:.*]]
51+
; CHECK: [[BB9]]:
52+
; CHECK-NEXT: ret void
53+
;
1354
bb6.lr.ph: ; preds = %bb5.preheader
1455
br label %bb6
1556

1657
bb6: ; preds = %bb6.lr.ph, %bb6
17-
%_tmp1423 = phi i64 [ undef, %bb6.lr.ph ], [ %_tmp142, %bb6 ]
18-
%_tmp123 = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 undef
58+
%_tmp1423 = phi i64 [ poison, %bb6.lr.ph ], [ %_tmp142, %bb6 ]
59+
%_tmp123 = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 poison
1960
%_tmp126 = getelementptr [3 x [5 x i16]], ptr %_tmp123, i16 0, i64 %_tmp1423
20-
%_tmp129 = getelementptr [5 x i16], ptr %_tmp126, i16 0, i64 undef
61+
%_tmp129 = getelementptr [5 x i16], ptr %_tmp126, i16 0, i64 poison
2162
%_tmp130 = load i16, ptr %_tmp129
22-
store i16 undef, ptr getelementptr ([2 x [3 x [5 x i16]]], ptr @x, i64 0, i64 undef, i64 undef, i64 undef)
63+
store i16 poison, ptr getelementptr ([2 x [3 x [5 x i16]]], ptr @x, i64 0, i64 poison, i64 poison, i64 poison)
2364
%_tmp142 = add i64 %_tmp1423, 1
2465
br i1 false, label %bb6, label %loop.exit
2566

2667
loop.exit: ; preds = %bb6
2768
%_tmp142.lcssa = phi i64 [ %_tmp142, %bb6 ]
28-
%split = phi i16 [ undef, %bb6 ]
29-
; CHECK: %split.ph = phi i16 [ undef, %bb6.lver.orig ]
30-
; CHECK: %split.ph3 = phi i16 [ undef, %bb6 ]
31-
; CHECK: %split = phi i16 [ %split.ph, %loop.exit.loopexit ], [ %split.ph3, %loop.exit.loopexit1 ]
69+
%split = phi i16 [ poison, %bb6 ]
3270
br label %bb9
3371

3472
bb9: ; preds = %bb9.loopexit, %bb1
3573
ret void
3674
}
3775

38-
; CHECK-LABEL: @phi_with_non_loop_defined_value
3976
define void @phi_with_non_loop_defined_value() {
77+
; CHECK-LABEL: define void @phi_with_non_loop_defined_value() {
78+
; CHECK-NEXT: [[BB6_LVER_CHECK:.*:]]
79+
; CHECK-NEXT: [[T:%.*]] = add i16 1, 1
80+
; CHECK-NEXT: [[MUL:%.*]] = call { i64, i1 } @llvm.umul.with.overflow.i64(i64 10, i64 0)
81+
; CHECK-NEXT: [[MUL_RESULT:%.*]] = extractvalue { i64, i1 } [[MUL]], 0
82+
; CHECK-NEXT: [[MUL_OVERFLOW:%.*]] = extractvalue { i64, i1 } [[MUL]], 1
83+
; CHECK-NEXT: [[TMP0:%.*]] = sub i64 0, [[MUL_RESULT]]
84+
; CHECK-NEXT: br i1 poison, label %[[BB6_PH_LVER_ORIG:.*]], label %[[BB6_PH:.*]]
85+
; CHECK: [[BB6_PH_LVER_ORIG]]:
86+
; CHECK-NEXT: br label %[[BB6_LVER_ORIG:.*]]
87+
; CHECK: [[BB6_LVER_ORIG]]:
88+
; CHECK-NEXT: [[_TMP1423_LVER_ORIG:%.*]] = phi i64 [ poison, %[[BB6_PH_LVER_ORIG]] ], [ [[_TMP142_LVER_ORIG:%.*]], %[[BB6_LVER_ORIG]] ]
89+
; CHECK-NEXT: [[_TMP123_LVER_ORIG:%.*]] = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 poison
90+
; CHECK-NEXT: [[_TMP126_LVER_ORIG:%.*]] = getelementptr [3 x [5 x i16]], ptr [[_TMP123_LVER_ORIG]], i16 0, i64 [[_TMP1423_LVER_ORIG]]
91+
; CHECK-NEXT: [[_TMP129_LVER_ORIG:%.*]] = getelementptr [5 x i16], ptr [[_TMP126_LVER_ORIG]], i16 0, i64 poison
92+
; CHECK-NEXT: [[_TMP130_LVER_ORIG:%.*]] = load i16, ptr [[_TMP129_LVER_ORIG]], align 2
93+
; CHECK-NEXT: store i16 poison, ptr @x, align 2
94+
; CHECK-NEXT: [[_TMP142_LVER_ORIG]] = add i64 [[_TMP1423_LVER_ORIG]], 1
95+
; CHECK-NEXT: br i1 false, label %[[BB6_LVER_ORIG]], label %[[LOOP_EXIT_LOOPEXIT:.*]]
96+
; CHECK: [[BB6_PH]]:
97+
; CHECK-NEXT: br label %[[BB6:.*]]
98+
; CHECK: [[BB6]]:
99+
; CHECK-NEXT: [[_TMP1423:%.*]] = phi i64 [ poison, %[[BB6_PH]] ], [ [[_TMP142:%.*]], %[[BB6]] ]
100+
; CHECK-NEXT: [[_TMP123:%.*]] = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 poison
101+
; CHECK-NEXT: [[_TMP126:%.*]] = getelementptr [3 x [5 x i16]], ptr [[_TMP123]], i16 0, i64 [[_TMP1423]]
102+
; CHECK-NEXT: [[_TMP129:%.*]] = getelementptr [5 x i16], ptr [[_TMP126]], i16 0, i64 poison
103+
; CHECK-NEXT: [[_TMP130:%.*]] = load i16, ptr [[_TMP129]], align 2
104+
; CHECK-NEXT: store i16 poison, ptr @x, align 2
105+
; CHECK-NEXT: [[_TMP142]] = add i64 [[_TMP1423]], 1
106+
; CHECK-NEXT: br i1 false, label %[[BB6]], label %[[LOOP_EXIT_LOOPEXIT1:.*]]
107+
; CHECK: [[LOOP_EXIT_LOOPEXIT]]:
108+
; CHECK-NEXT: [[_TMP142_LCSSA_PH:%.*]] = phi i64 [ [[_TMP142_LVER_ORIG]], %[[BB6_LVER_ORIG]] ]
109+
; CHECK-NEXT: [[SPLIT_PH:%.*]] = phi i16 [ [[T]], %[[BB6_LVER_ORIG]] ]
110+
; CHECK-NEXT: br label %[[LOOP_EXIT:.*]]
111+
; CHECK: [[LOOP_EXIT_LOOPEXIT1]]:
112+
; CHECK-NEXT: [[_TMP142_LCSSA_PH2:%.*]] = phi i64 [ [[_TMP142]], %[[BB6]] ]
113+
; CHECK-NEXT: [[SPLIT_PH3:%.*]] = phi i16 [ [[T]], %[[BB6]] ]
114+
; CHECK-NEXT: br label %[[LOOP_EXIT]]
115+
; CHECK: [[LOOP_EXIT]]:
116+
; CHECK-NEXT: [[_TMP142_LCSSA:%.*]] = phi i64 [ [[_TMP142_LCSSA_PH]], %[[LOOP_EXIT_LOOPEXIT]] ], [ [[_TMP142_LCSSA_PH2]], %[[LOOP_EXIT_LOOPEXIT1]] ]
117+
; CHECK-NEXT: [[SPLIT:%.*]] = phi i16 [ [[SPLIT_PH]], %[[LOOP_EXIT_LOOPEXIT]] ], [ [[SPLIT_PH3]], %[[LOOP_EXIT_LOOPEXIT1]] ]
118+
; CHECK-NEXT: br label %[[BB9:.*]]
119+
; CHECK: [[BB9]]:
120+
; CHECK-NEXT: ret void
121+
;
40122
bb6.lr.ph: ; preds = %bb5.preheader
41123
%t = add i16 1, 1
42124
br label %bb6
43125

44126
bb6: ; preds = %bb6.lr.ph, %bb6
45-
%_tmp1423 = phi i64 [ undef, %bb6.lr.ph ], [ %_tmp142, %bb6 ]
46-
%_tmp123 = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 undef
127+
%_tmp1423 = phi i64 [ poison, %bb6.lr.ph ], [ %_tmp142, %bb6 ]
128+
%_tmp123 = getelementptr [2 x [3 x [5 x i16]]], ptr @x, i16 0, i64 poison
47129
%_tmp126 = getelementptr [3 x [5 x i16]], ptr %_tmp123, i16 0, i64 %_tmp1423
48-
%_tmp129 = getelementptr [5 x i16], ptr %_tmp126, i16 0, i64 undef
130+
%_tmp129 = getelementptr [5 x i16], ptr %_tmp126, i16 0, i64 poison
49131
%_tmp130 = load i16, ptr %_tmp129
50-
store i16 undef, ptr getelementptr ([2 x [3 x [5 x i16]]], ptr @x, i64 0, i64 undef, i64 undef, i64 undef)
132+
store i16 poison, ptr getelementptr ([2 x [3 x [5 x i16]]], ptr @x, i64 0, i64 poison, i64 poison, i64 poison)
51133
%_tmp142 = add i64 %_tmp1423, 1
52134
br i1 false, label %bb6, label %loop.exit
53135

54136
loop.exit: ; preds = %bb6
55137
%_tmp142.lcssa = phi i64 [ %_tmp142, %bb6 ]
56138
%split = phi i16 [ %t, %bb6 ]
57-
; CHECK: %split.ph = phi i16 [ %t, %bb6.lver.orig ]
58-
; CHECK: %split.ph3 = phi i16 [ %t, %bb6 ]
59-
; CHECK: %split = phi i16 [ %split.ph, %loop.exit.loopexit ], [ %split.ph3, %loop.exit.loopexit1 ]
60139
br label %bb9
61140

62141
bb9: ; preds = %bb9.loopexit, %bb1

0 commit comments

Comments
 (0)