Skip to content

Commit ab03a84

Browse files
[mlir][Analysis][NFC] Disambiguate FlatAffineConstraints constructor
The following constructor call (and others) used to be ambiguous: ``` FlatAffineConstraints constraints(0, 0, 0); ``` Differential Revision: https://reviews.llvm.org/D107726
1 parent 27c2fa4 commit ab03a84

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

mlir/include/mlir/Analysis/AffineStructures.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,8 +64,8 @@ class FlatAffineConstraints {
6464
/// of constraints and identifiers..
6565
FlatAffineConstraints(unsigned numReservedInequalities,
6666
unsigned numReservedEqualities,
67-
unsigned numReservedCols, unsigned numDims = 0,
68-
unsigned numSymbols = 0, unsigned numLocals = 0,
67+
unsigned numReservedCols, unsigned numDims,
68+
unsigned numSymbols, unsigned numLocals,
6969
ArrayRef<Optional<Value>> idArgs = {})
7070
: numIds(numDims + numSymbols + numLocals), numDims(numDims),
7171
numSymbols(numSymbols),

mlir/unittests/Analysis/AffineStructuresTest.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ static FlatAffineConstraints
5656
makeFACFromConstraints(unsigned ids, ArrayRef<SmallVector<int64_t, 4>> ineqs,
5757
ArrayRef<SmallVector<int64_t, 4>> eqs,
5858
unsigned syms = 0) {
59-
FlatAffineConstraints fac(ineqs.size(), eqs.size(), ids + 1, ids - syms,
60-
syms);
59+
FlatAffineConstraints fac(ineqs.size(), eqs.size(), ids + 1, ids - syms, syms,
60+
/*numLocals=*/0);
6161
for (const auto &eq : eqs)
6262
fac.addEquality(eq);
6363
for (const auto &ineq : ineqs)

mlir/unittests/Analysis/PresburgerSetTest.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,8 @@ static void testComplementAtPoints(PresburgerSet s,
8484
static FlatAffineConstraints
8585
makeFACFromConstraints(unsigned dims, ArrayRef<SmallVector<int64_t, 4>> ineqs,
8686
ArrayRef<SmallVector<int64_t, 4>> eqs) {
87-
FlatAffineConstraints fac(ineqs.size(), eqs.size(), dims + 1, dims);
87+
FlatAffineConstraints fac(ineqs.size(), eqs.size(), dims + 1, dims,
88+
/*numSymbols=*/0, /*numLocals=*/0);
8889
for (const SmallVector<int64_t, 4> &eq : eqs)
8990
fac.addEquality(eq);
9091
for (const SmallVector<int64_t, 4> &ineq : ineqs)

0 commit comments

Comments
 (0)