Revert "Fix MSVC "not all control paths return a value" warnings. NFCI."

aeubanks · aeubanks · commit ab7a60eb4100 · 2020-12-22T10:18:07.000-08:00
This reverts commit 7e84aa1. This is part of 5 commits being reverted due to https://crbug.com/1161059. See bug for repro.
diff --git a/clang/lib/Sema/SemaTemplate.cpp b/clang/lib/Sema/SemaTemplate.cpp
@@ -7637,7 +7637,6 @@ static Expr *BuildExpressionFromNonTypeTemplateArgumentValue(
     auto *OVE = new (S.Context) OpaqueValueExpr(Loc, T, VK);
     return ConstantExpr::Create(S.Context, OVE, Val);
   }
-  llvm_unreachable("Unhandled APValue::ValueKind enum");
 }
 
 ExprResult
@@ -7667,7 +7666,6 @@ Sema::BuildExpressionFromNonTypeTemplateArgument(const TemplateArgument &Arg,
     return BuildExpressionFromNonTypeTemplateArgumentValue(
         *this, Arg.getUncommonValueType(), Arg.getAsUncommonValue(), Loc);
   }
-  llvm_unreachable("Unhandled TemplateArgument::ArgKind enum");
 }
 
 /// Match two template parameters within template parameter lists.

Original file line number	Diff line number	Diff line change
`@@ -7637,7 +7637,6 @@ static Expr *BuildExpressionFromNonTypeTemplateArgumentValue(`
`7637`	`7637`	`auto *OVE = new (S.Context) OpaqueValueExpr(Loc, T, VK);`
`7638`	`7638`	`return ConstantExpr::Create(S.Context, OVE, Val);`
`7639`	`7639`	`}`
`7640`		`- llvm_unreachable("Unhandled APValue::ValueKind enum");`
`7641`	`7640`	`}`
`7642`	`7641`
`7643`	`7642`	`ExprResult`
`@@ -7667,7 +7666,6 @@ Sema::BuildExpressionFromNonTypeTemplateArgument(const TemplateArgument &Arg,`
`7667`	`7666`	`return BuildExpressionFromNonTypeTemplateArgumentValue(`
`7668`	`7667`	`*this, Arg.getUncommonValueType(), Arg.getAsUncommonValue(), Loc);`
`7669`	`7668`	`}`
`7670`		`- llvm_unreachable("Unhandled TemplateArgument::ArgKind enum");`
`7671`	`7669`	`}`
`7672`	`7670`
`7673`	`7671`	`/// Match two template parameters within template parameter lists.`