Skip to content

Commit abe8de2

Browse files
committed
Revert "Temporarily revert "build: avoid hardcoding the libxml2 library name""
This reverts commit 2e75681. Restore the clean up change. The underlying CMake issue was resolved in 372ad32.
1 parent 26748a3 commit abe8de2

File tree

2 files changed

+6
-13
lines changed

2 files changed

+6
-13
lines changed

llvm/cmake/config-ix.cmake

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,6 @@ if(NOT LLVM_USE_SANITIZER MATCHES "Memory.*")
166166
else()
167167
include_directories(${LIBXML2_INCLUDE_DIR})
168168
endif()
169-
set(LIBXML2_LIBS "xml2")
170169
endif()
171170
endif()
172171
endif()
Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,12 @@
1-
set(system_libs)
2-
if( CMAKE_HOST_UNIX )
3-
if( LLVM_LIBXML2_ENABLED )
4-
set(system_libs ${system_libs} ${LIBXML2_LIBS})
5-
endif()
6-
endif()
7-
81
add_llvm_component_library(LLVMWindowsManifest
92
WindowsManifestMerger.cpp
103

114
ADDITIONAL_HEADER_DIRS
125
${LLVM_MAIN_INCLUDE_DIR}/llvm/WindowsManifest
13-
${Backtrace_INCLUDE_DIRS}
6+
${Backtrace_INCLUDE_DIRS})
147

15-
LINK_LIBS ${system_libs}
16-
)
17-
18-
set_property(TARGET LLVMWindowsManifest PROPERTY LLVM_SYSTEM_LIBS "${system_libs}")
8+
if(LIBXML2_LIBRARIES)
9+
target_link_libraries(LLVMWindowsManifest PUBLIC ${LIBXML2_LIBRARIES})
10+
set_property(TARGET LLVMWindowsManifest PROPERTY
11+
LLVM_SYSTEM_LIBS ${LIBXML2_LIBRARIES})
12+
endif()

0 commit comments

Comments
 (0)