Add and use ShouldIgnoreArtificialField API to ignore the indeed artificial

members we should ignore.

Author: hokein

lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp

@@ -3059,10 +3059,8 @@ void DWARFASTParserClang::ParseSingleMember(
   // This needs to be done after updating FieldInfo which keeps track of where
   // field start/end so we don't later try to fill the space of this
   // artificial member with (unnamed bitfield) padding.
-  // FIXME: This check should verify that this is indeed an artificial member
-  // we are supposed to ignore.
   if (attrs.is_artificial &&
-      !TypeSystemClang::IsCoroutineFrameType(class_clang_type)) {
+      TypeSystemClang::ShouldIgnoreArtificialField(attrs.name)) {
     last_field_info.SetIsArtificial(true);
     return;
   }

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp

@@ -771,8 +771,8 @@ TypeSystemClang *TypeSystemClang::GetASTContext(clang::ASTContext *ast) {
   return clang_ast;
 }
 
-bool TypeSystemClang::IsCoroutineFrameType(const CompilerType &Type) {
-  return Type.GetTypeName().GetStringRef().ends_with(".coro_frame_ty");
+bool TypeSystemClang::ShouldIgnoreArtificialField(llvm::StringRef Name) {
+  return Name.starts_with("_vptr$");
 }
 
 clang::MangleContext *TypeSystemClang::getMangleContext() {

lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.h

@@ -154,8 +154,9 @@ class TypeSystemClang : public TypeSystem {
 
   static TypeSystemClang *GetASTContext(clang::ASTContext *ast_ctx);
 
-  // Returns true if the given type is a coroutine frame debug type.
-  static bool IsCoroutineFrameType(const CompilerType &Type);
+  // Returns true if the given artificial field name should be ignored when
+  // parsing the DWARF.
+  static bool ShouldIgnoreArtificialField(llvm::StringRef FieldName);
 
   /// Returns the display name of this TypeSystemClang that indicates what
   /// purpose it serves in LLDB. Used for example in logs.