Skip to content

Commit ad01635

Browse files
authored
[libc++] Fix sized deallocation comments in tests (#98173)
Clang 19 turned on sized deallocation *by default*, but older versions of Clang did support sized deallocation nonetheless. This updates a few comments and removes UNSUPPORTED annotations that shouldn't be needed in a test that passes -fsized-deallocation directly.
1 parent d100631 commit ad01635

File tree

3 files changed

+4
-7
lines changed

3 files changed

+4
-7
lines changed

libcxx/test/libcxx/language.support/support.dynamic/libcpp_deallocate.sh.cpp

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// test libc++'s implementation of align_val_t, and the relevant new/delete
9+
// Test libc++'s implementation of align_val_t, and the relevant new/delete
1010
// overloads in all dialects when -faligned-allocation is present.
1111

1212
// Libc++ when built for z/OS doesn't contain the aligned allocation functions,
@@ -21,9 +21,6 @@
2121
// GCC doesn't support the aligned-allocation flags.
2222
// XFAIL: gcc
2323

24-
// These compiler versions do not have proper sized deallocation support.
25-
// UNSUPPORTED: clang-17, clang-18
26-
2724
// RUN: %{build} -faligned-allocation -fsized-deallocation
2825
// RUN: %{run}
2926
// RUN: %{build} -faligned-allocation -fno-sized-deallocation -DNO_SIZE

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88

99
// test sized operator delete[] replacement.
1010

11-
// These compiler versions do not have proper sized deallocation support.
11+
// These compiler versions don't enable sized deallocation by default.
1212
// UNSUPPORTED: clang-17, clang-18
1313

1414
// UNSUPPORTED: sanitizer-new-delete, c++03, c++11

libcxx/test/std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,9 +6,9 @@
66
//
77
//===----------------------------------------------------------------------===//
88

9-
// test sized operator delete replacement.
9+
// Test sized operator delete replacement.
1010

11-
// These compiler versions do not have proper sized deallocation support.
11+
// These compiler versions do not enable sized deallocation by default.
1212
// UNSUPPORTED: clang-17, clang-18
1313

1414
// UNSUPPORTED: sanitizer-new-delete, c++03, c++11

0 commit comments

Comments
 (0)