[mlir] Fix MLIRTestDialect dependency in MLIRTestIR (#125705)

nikic · web-flow · commit ad152f4bcfe4 · 2025-02-05T10:09:35.000+01:00
This is a test library which is not part of libMLIR, so it should use normal LINK_LIBS instead of mlir_target_link_libraries. This fixes an issue introduced in #123910 and follows up on the fix in #125004, which added the library to DEPENDS, which is not sufficient.
diff --git a/mlir/test/lib/IR/CMakeLists.txt b/mlir/test/lib/IR/CMakeLists.txt
@@ -28,7 +28,7 @@ add_mlir_library(MLIRTestIR
 
   EXCLUDE_FROM_LIBMLIR
 
-  DEPENDS
+  LINK_LIBS PUBLIC
   MLIRTestDialect
   )
 
@@ -37,7 +37,6 @@ mlir_target_link_libraries(MLIRTestIR PUBLIC
   MLIRBytecodeReader
   MLIRBytecodeWriter
   MLIRFunctionInterfaces
-  MLIRTestDialect
   )
 
 target_include_directories(MLIRTestIR

Original file line number	Diff line number	Diff line change
`@@ -28,7 +28,7 @@ add_mlir_library(MLIRTestIR`
`28`	`28`
`29`	`29`	`EXCLUDE_FROM_LIBMLIR`
`30`	`30`
`31`		`- DEPENDS`
	`31`	`+ LINK_LIBS PUBLIC`
`32`	`32`	`MLIRTestDialect`
`33`	`33`	`)`
`34`	`34`
`@@ -37,7 +37,6 @@ mlir_target_link_libraries(MLIRTestIR PUBLIC`
`37`	`37`	`MLIRBytecodeReader`
`38`	`38`	`MLIRBytecodeWriter`
`39`	`39`	`MLIRFunctionInterfaces`
`40`		`- MLIRTestDialect`
`41`	`40`	`)`
`42`	`41`
`43`	`42`	`target_include_directories(MLIRTestIR`