[mlir] Changed walk to visit child blocks for each operation

Signed-off-by: ikulagin <[email protected]>

Author: ikulagin

mlir/lib/Analysis/Liveness.cpp

@@ -67,18 +67,16 @@ struct BlockInfoBuilder {
     // Mark all nested operation results as defined, and nested operation
     // operands as used. All defined value will be removed from the used set
     // at the end.
-    block->walk([&](Block *nestedBlock) {
-      if (block != nestedBlock) {
-        for (BlockArgument arg : nestedBlock->getArguments()) {
-          defValues.insert(arg);
-        }
-      }
-      for (Operation &op : *nestedBlock) {
-        for (Value result : op.getResults())
-          defValues.insert(result);
-        for (Value operand : op.getOperands())
-          useValues.insert(operand);
-      }
+    block->walk([&](Operation *op) {
+      for (Value result : op->getResults())
+        defValues.insert(result);
+      for (Value operand : op->getOperands())
+        useValues.insert(operand);
+      for (Region &region : op->getRegions())
+        for (Block &child : region.getBlocks())
+          for (BlockArgument arg : child.getArguments()) {
+            defValues.insert(arg);
+          }
     });
     llvm::set_subtract(useValues, defValues);
   }

mlir/test/Analysis/test-liveness.mlir

@@ -500,8 +500,8 @@ func.func @nested_region3(
 
 func.func @nested_region4(%arg0: index, %arg1: index, %arg2: index) {
   // CHECK: Block: 0
-  // CHECK-NEXT: LiveIn:
-  // CHECK-NEXT: LiveOut:
+  // CHECK-NEXT: LiveIn:{{ *$}}
+  // CHECK-NEXT: LiveOut:{{ *$}}
   // CHECK-NEXT: BeginLivenessIntervals
   // CHECK-NEXT: val_3
   // CHECK-NEXT: %c0_i32 = arith.constant 0
@@ -532,7 +532,7 @@ func.func @nested_region4(%arg0: index, %arg1: index, %arg2: index) {
   %0 = scf.for %arg3 = %arg0 to %arg1 step %arg2 iter_args(%arg4 = %c0_i32) -> (i32) {
     // CHECK-NEXT: Block: 1
     // CHECK-NEXT: LiveIn: val_4
-    // CHECK-NEXT: LiveOut:
+    // CHECK-NEXT: LiveOut:{{ *$}}
     // CHECK-NEXT: BeginLivenessIntervals
     // CHECK-NEXT: val_8
     // CHECK-NEXT: %1 = arith.addi