Skip to content

Commit aefcded

Browse files
authored
[flang][HLFIR][NFC] Reduce BufferizeHLFIR pass boilerplate (#93161)
The pass constructor can be generated automatically. This pass is module-level and then runs on all of the relevant HLFIR operations inside of the module, no matter what top level operation they are inside of.
1 parent 9b79ace commit aefcded

File tree

4 files changed

+1
-7
lines changed

4 files changed

+1
-7
lines changed

flang/include/flang/Optimizer/HLFIR/Passes.h

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,6 @@ namespace hlfir {
2323
#include "flang/Optimizer/HLFIR/Passes.h.inc"
2424

2525
std::unique_ptr<mlir::Pass> createConvertHLFIRtoFIRPass();
26-
std::unique_ptr<mlir::Pass> createBufferizeHLFIRPass();
2726

2827
#define GEN_PASS_REGISTRATION
2928
#include "flang/Optimizer/HLFIR/Passes.h.inc"

flang/include/flang/Optimizer/HLFIR/Passes.td

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ def ConvertHLFIRtoFIR : Pass<"convert-hlfir-to-fir", "::mlir::ModuleOp"> {
2020

2121
def BufferizeHLFIR : Pass<"bufferize-hlfir", "::mlir::ModuleOp"> {
2222
let summary = "Convert HLFIR operations operating on hlfir.expr into operations on memory";
23-
let constructor = "hlfir::createBufferizeHLFIRPass()";
2423
}
2524

2625
def OptimizedBufferization : Pass<"opt-bufferization"> {

flang/include/flang/Tools/CLOptions.inc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -330,7 +330,7 @@ inline void createHLFIRToFIRPassPipeline(
330330
}
331331
pm.addPass(hlfir::createLowerHLFIROrderedAssignments());
332332
pm.addPass(hlfir::createLowerHLFIRIntrinsics());
333-
pm.addPass(hlfir::createBufferizeHLFIRPass());
333+
pm.addPass(hlfir::createBufferizeHLFIR());
334334
pm.addPass(hlfir::createConvertHLFIRtoFIRPass());
335335
}
336336

flang/lib/Optimizer/HLFIR/Transforms/BufferizeHLFIR.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -944,7 +944,3 @@ class BufferizeHLFIR : public hlfir::impl::BufferizeHLFIRBase<BufferizeHLFIR> {
944944
}
945945
};
946946
} // namespace
947-
948-
std::unique_ptr<mlir::Pass> hlfir::createBufferizeHLFIRPass() {
949-
return std::make_unique<BufferizeHLFIR>();
950-
}

0 commit comments

Comments
 (0)