Skip to content

Commit af031a9

Browse files
committed
Avoid redundant error when redefining a function as deleted.
Reviewed by Doug Gregor. llvm-svn: 159442
1 parent 674acc1 commit af031a9

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

clang/lib/Sema/SemaDeclCXX.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10318,8 +10318,8 @@ void Sema::SetDeclDeleted(Decl *Dcl, SourceLocation DelLoc) {
1031810318
if (const FunctionDecl *Prev = Fn->getPreviousDecl()) {
1031910319
// Don't consider the implicit declaration we generate for explicit
1032010320
// specializations. FIXME: Do not generate these implicit declarations.
10321-
if (Prev->getTemplateSpecializationKind() != TSK_ExplicitSpecialization
10322-
|| Prev->getPreviousDecl()) {
10321+
if ((Prev->getTemplateSpecializationKind() != TSK_ExplicitSpecialization
10322+
|| Prev->getPreviousDecl()) && !Prev->isDefined()) {
1032310323
Diag(DelLoc, diag::err_deleted_decl_not_first);
1032410324
Diag(Prev->getLocation(), diag::note_previous_declaration);
1032510325
}

clang/test/SemaCXX/deleted-function.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,3 +63,6 @@ template void test2<int>();
6363
template<typename> void test3() = delete; // expected-note {{explicit instantiation refers here}}
6464
template<typename> void test3();
6565
template void test3<int>(); // expected-error {{explicit instantiation of undefined function template 'test3'}}
66+
67+
void test4() {} // expected-note {{previous definition is here}}
68+
void test4() = delete; // expected-error {{redefinition of 'test4'}}

0 commit comments

Comments
 (0)